1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Expose http parse error codes

Browse Source 
Currently http parse errors do not expose the error details available
from http_parser. This patch exposes the error code as `err.code`.
This commit is contained in:
Felix Geisendörfer 2011-12-18 15:55:40 +01:00 committed by isaacs
parent 891f9defeb
commit 18240193ba
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/node_http_parser.cc
View File

@ -432,9 +432,12 @@ public:
// If there was a parse error in one of the callbacks // If there was a parse error in one of the callbacks
// TODO What if there is an error on EOF? // TODO What if there is an error on EOF?
if (!parser->parser_.upgrade && nparsed != len) { if (!parser->parser_.upgrade && nparsed != len) {
enum http_errno err = HTTP_PARSER_ERRNO(&parser->parser_);
Local<Value> e = Exception::Error(String::NewSymbol("Parse Error")); Local<Value> e = Exception::Error(String::NewSymbol("Parse Error"));
Local<Object> obj = e->ToObject(); Local<Object> obj = e->ToObject();
obj->Set(String::NewSymbol("bytesParsed"), nparsed_obj); obj->Set(String::NewSymbol("bytesParsed"), nparsed_obj);
obj->Set(String::NewSymbol("code"), String::New(http_errno_name(err)));
return scope.Close(e); return scope.Close(e);
} else { } else {
return scope.Close(nparsed_obj); return scope.Close(nparsed_obj);
@ -455,9 +458,12 @@ public:
if (parser->got_exception_) return Local<Value>(); if (parser->got_exception_) return Local<Value>();
if (rv != 0) { if (rv != 0) {
enum http_errno err = HTTP_PARSER_ERRNO(&parser->parser_);
Local<Value> e = Exception::Error(String::NewSymbol("Parse Error")); Local<Value> e = Exception::Error(String::NewSymbol("Parse Error"));
Local<Object> obj = e->ToObject(); Local<Object> obj = e->ToObject();
obj->Set(String::NewSymbol("bytesParsed"), Integer::New(0)); obj->Set(String::NewSymbol("bytesParsed"), Integer::New(0));
obj->Set(String::NewSymbol("code"), String::New(http_errno_name(err)));
return scope.Close(e); return scope.Close(e);
} }

1
test/simple/test-http-client-parse-error.js
View File

@ -48,6 +48,7 @@ srv.listen(common.PORT, '127.0.0.1', function() {
console.log('got error from client'); console.log('got error from client');
srv.close(); srv.close();
assert.ok(e.message.indexOf('Parse Error') >= 0); assert.ok(e.message.indexOf('Parse Error') >= 0);
assert.equal(e.code, 'HPE_INVALID_CONSTANT');
parseError = true; parseError = true;
}); });
}); });