1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve test-fs-write-stream-throw-type

Browse Source 
* validate the errors for all assert.throws
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Adrian Estrada 2017-01-12 19:27:01 -05:00 committed by James M Snell
parent 8628c93499
commit 1699a8ad71
1 changed files with 24 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
test/parallel/test-fs-write-stream-throw-type-error.js
View File

@ -4,32 +4,44 @@ const assert = require('assert');
const fs = require('fs'); const fs = require('fs');
const path = require('path'); const path = require('path');
const numberError = new RegExp('^TypeError: "options" must be a string ' +
'or an object, got number instead.$');
const booleanError = new RegExp('^TypeError: "options" must be a string ' +
'or an object, got boolean instead.$');
const example = path.join(common.tmpDir, 'dummy'); const example = path.join(common.tmpDir, 'dummy');
common.refreshTmpDir(); common.refreshTmpDir();
assert.doesNotThrow(function() { assert.doesNotThrow(() => {
fs.createWriteStream(example, undefined); fs.createWriteStream(example, undefined);
}); });
assert.doesNotThrow(function() {
assert.doesNotThrow(() => {
fs.createWriteStream(example, null); fs.createWriteStream(example, null);
}); });
assert.doesNotThrow(function() {
assert.doesNotThrow(() => {
fs.createWriteStream(example, 'utf8'); fs.createWriteStream(example, 'utf8');
}); });
assert.doesNotThrow(function() {
assert.doesNotThrow(() => {
fs.createWriteStream(example, {encoding: 'utf8'}); fs.createWriteStream(example, {encoding: 'utf8'});
}); });
assert.throws(function() { assert.throws(() => {
fs.createWriteStream(example, 123); fs.createWriteStream(example, 123);
}, /"options" must be a string or an object/); }, numberError);
assert.throws(function() {
assert.throws(() => {
fs.createWriteStream(example, 0); fs.createWriteStream(example, 0);
}, /"options" must be a string or an object/); }, numberError);
assert.throws(function() {
assert.throws(() => {
fs.createWriteStream(example, true); fs.createWriteStream(example, true);
}, /"options" must be a string or an object/); }, booleanError);
assert.throws(function() {
assert.throws(() => {
fs.createWriteStream(example, false); fs.createWriteStream(example, false);
}, /"options" must be a string or an object/); }, booleanError);