1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: organize imports in inspector_profiler.cc

Browse Source 
In the other .cc files in the project, includes are in alphabetical
order, with local files first, and libraries after. However,
inspector_profiler.cc has a library declared in the middle of the import
order, and v8 is the second to last being imported, instead of the last.
So I reordered the imports and testing showed no side effects;
everything passed.

PR-URL: https://github.com/nodejs/node/pull/29073
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This commit is contained in:
pi1024e 2019-08-09 11:15:22 -04:00 committed by Rich Trott
parent 7635b7cc27
commit 15b2d13310
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/inspector_profiler.cc
View File

@ -1,13 +1,14 @@
#include "inspector_profiler.h"
#include <sstream>
#include "base_object-inl.h"
#include "debug_utils.h"
#include "diagnosticfilename-inl.h"
#include "memory_tracker-inl.h"
#include "node_file.h"
#include "node_internals.h"
#include "v8-inspector.h"
#include "util-inl.h"
#include "v8-inspector.h"
#include <sstream>
namespace node {
namespace profiler {
@ -323,7 +324,7 @@ void EndStartedProfilers(Environment* env) {
std::string GetCwd(Environment* env) {
char cwd[PATH_MAX_BYTES];
size_t size = PATH_MAX_BYTES;
int err = uv_cwd(cwd, &size);
const int err = uv_cwd(cwd, &size);
if (err == 0) {
CHECK_GT(size, 0);