1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: update 2fa information in onboarding.md

Browse Source 
Because it is no longer possible to add someone to the nodejs GitHub
organization if they do not have two-factor authentication enabled,
update the text of the onboarding documentatino to reflect this.

PR-URL: https://github.com/nodejs/node/pull/18968
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
This commit is contained in:
Rich Trott 2018-02-23 16:29:45 -08:00 committed by Leko
parent 65ca369c07
commit 1460b31bd3
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
doc/onboarding.md
View File

@ -5,10 +5,10 @@ onboarding session.
## One week before the onboarding session ## One week before the onboarding session
* Confirm that the new Collaborator is using two-factor authentication on their * If the new Collaborator is not yet a member of the nodejs GitHub organization,
GitHub account. Unless two-factor authentication is enabled, do not give an confirm that they are using two-factor authentication. It will not be possible
account elevated privileges such as the ability to land code in the main to add them to the organization if they are not using two-factor
repository or to start continuous integration (CI) jobs. authentication.
* Announce the accepted nomination in a TSC meeting and in the TSC * Announce the accepted nomination in a TSC meeting and in the TSC
mailing list. mailing list.
@ -16,9 +16,6 @@ onboarding session.
* Prior to the onboarding session, add the new Collaborator to * Prior to the onboarding session, add the new Collaborator to
[the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators). [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators).
Note that this is the step that gives the account elevated privileges, so do
not perform this step (or any subsequent steps) unless two-factor
authentication is enabled on the new Collaborator's GitHub account.
## Onboarding session ## Onboarding session