From 13c5db977190f926a213fc8ad7204e1febe36009 Mon Sep 17 00:00:00 2001 From: Trevor Norris Date: Fri, 9 Nov 2012 14:02:45 -0800 Subject: [PATCH] buffer: remove duplicate assertion tests Many assertion tests are duplicated in buffer.js. These few could be easily removed and still have all tests pass. --- lib/buffer.js | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/lib/buffer.js b/lib/buffer.js index 2e1d6a045db..6c9753e888a 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -1047,15 +1047,6 @@ Buffer.prototype.writeInt8 = function(value, offset, noAssert) { var buffer = this; if (!noAssert) { - assert.ok(value !== undefined && value !== null, - 'missing value'); - - assert.ok(offset !== undefined && offset !== null, - 'missing offset'); - - assert.ok(offset < buffer.length, - 'Trying to write beyond buffer length'); - verifsint(value, 0x7f, -0x80); } @@ -1068,18 +1059,6 @@ Buffer.prototype.writeInt8 = function(value, offset, noAssert) { function writeInt16(buffer, value, offset, isBigEndian, noAssert) { if (!noAssert) { - assert.ok(value !== undefined && value !== null, - 'missing value'); - - assert.ok(typeof (isBigEndian) === 'boolean', - 'missing or invalid endian'); - - assert.ok(offset !== undefined && offset !== null, - 'missing offset'); - - assert.ok(offset + 1 < buffer.length, - 'Trying to write beyond buffer length'); - verifsint(value, 0x7fff, -0x8000); } @@ -1100,18 +1079,6 @@ Buffer.prototype.writeInt16BE = function(value, offset, noAssert) { function writeInt32(buffer, value, offset, isBigEndian, noAssert) { if (!noAssert) { - assert.ok(value !== undefined && value !== null, - 'missing value'); - - assert.ok(typeof (isBigEndian) === 'boolean', - 'missing or invalid endian'); - - assert.ok(offset !== undefined && offset !== null, - 'missing offset'); - - assert.ok(offset + 3 < buffer.length, - 'Trying to write beyond buffer length'); - verifsint(value, 0x7fffffff, -0x80000000); }