1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: run eslint on test file and fix errors

Browse Source 
This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: https://github.com/nodejs/node/pull/25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-12-13 09:35:55 +01:00 committed by Rich Trott
parent 83360899db
commit 1395256187
2 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.eslintignore
View File

@ -1,9 +1,7 @@
node_modules node_modules
lib/internal/v8.js
lib/internal/v8_prof_polyfill.js lib/internal/v8_prof_polyfill.js
lib/punycode.js lib/punycode.js
test/addons/??_* test/addons/??_*
test/es-module/test-esm-dynamic-import.js
test/fixtures test/fixtures
test/message/esm_display_syntax_error.mjs test/message/esm_display_syntax_error.mjs
tools/icu tools/icu

19
test/es-module/test-esm-dynamic-import.js
View File

@ -11,7 +11,7 @@ targetURL.pathname = absolutePath;
function expectErrorProperty(result, propertyKey, value) { function expectErrorProperty(result, propertyKey, value) {
Promise.resolve(result) Promise.resolve(result)
.catch(common.mustCall(error => { .catch(common.mustCall((error) => {
assert.strictEqual(error[propertyKey], value); assert.strictEqual(error[propertyKey], value);
})); }));
} }
@ -22,15 +22,16 @@ function expectMissingModuleError(result) {
function expectOkNamespace(result) { function expectOkNamespace(result) {
Promise.resolve(result) Promise.resolve(result)
.then(common.mustCall(ns => { .then(common.mustCall((ns) => {
// Can't deepStrictEqual because ns isn't a normal object // Can't deepStrictEqual because ns isn't a normal object
// eslint-disable-next-line no-restricted-properties
assert.deepEqual(ns, { default: true }); assert.deepEqual(ns, { default: true });
})); }));
} }
function expectFsNamespace(result) { function expectFsNamespace(result) {
Promise.resolve(result) Promise.resolve(result)
.then(common.mustCall(ns => { .then(common.mustCall((ns) => {
assert.strictEqual(typeof ns.default.writeFile, 'function'); assert.strictEqual(typeof ns.default.writeFile, 'function');
assert.strictEqual(typeof ns.writeFile, 'function'); assert.strictEqual(typeof ns.writeFile, 'function');
})); }));
@ -41,19 +42,19 @@ function expectFsNamespace(result) {
(function testScriptOrModuleImport() { (function testScriptOrModuleImport() {
// Importing another file, both direct & via eval // Importing another file, both direct & via eval
// expectOkNamespace(import(relativePath)); // expectOkNamespace(import(relativePath));
expectOkNamespace(eval.call(null, `import("${relativePath}")`));
expectOkNamespace(eval(`import("${relativePath}")`)); expectOkNamespace(eval(`import("${relativePath}")`));
expectOkNamespace(eval.call(null, `import("${targetURL}")`)); expectOkNamespace(eval(`import("${relativePath}")`));
expectOkNamespace(eval(`import("${targetURL}")`));
// Importing a built-in, both direct & via eval // Importing a built-in, both direct & via eval
expectFsNamespace(import("fs")); expectFsNamespace(import('fs'));
expectFsNamespace(eval('import("fs")'));
expectFsNamespace(eval('import("fs")')); expectFsNamespace(eval('import("fs")'));
expectFsNamespace(eval.call(null, 'import("fs")'));
expectMissingModuleError(import("./not-an-existing-module.mjs")); expectMissingModuleError(import('./not-an-existing-module.mjs'));
// TODO(jkrems): Right now this doesn't hit a protocol error because the // TODO(jkrems): Right now this doesn't hit a protocol error because the
// module resolution step already rejects it. These arguably should be // module resolution step already rejects it. These arguably should be
// protocol errors. // protocol errors.
expectMissingModuleError(import("node:fs")); expectMissingModuleError(import('node:fs'));
expectMissingModuleError(import('http://example.com/foo.js')); expectMissingModuleError(import('http://example.com/foo.js'));
})(); })();