1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tools: add falsely removed eslint rules

Browse Source 
This adds the eslint rules back in that were falsely removed while
landing https://github.com/nodejs/node/pull/18566.

PR-URL: https://github.com/nodejs/node/pull/18933
Refs: https://github.com/nodejs/node/pull/18566
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-02-22 12:50:50 +01:00
parent 95bae85809
commit 13637d23f7
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.eslintrc.js
View File

@ -71,6 +71,7 @@ module.exports = {
'accessor-pairs': 'error', 'accessor-pairs': 'error',
'array-callback-return': 'error', 'array-callback-return': 'error',
'dot-location': ['error', 'property'], 'dot-location': ['error', 'property'],
'dot-notation': 'error',
eqeqeq: ['error', 'smart'], eqeqeq: ['error', 'smart'],
'no-fallthrough': 'error', 'no-fallthrough': 'error',
'no-global-assign': 'error', 'no-global-assign': 'error',
@ -111,6 +112,7 @@ module.exports = {
], ],
'no-return-await': 'error', 'no-return-await': 'error',
'no-self-assign': 'error', 'no-self-assign': 'error',
'no-self-compare': 'error',
'no-throw-literal': 'error', 'no-throw-literal': 'error',
'no-unused-labels': 'error', 'no-unused-labels': 'error',
'no-useless-call': 'error', 'no-useless-call': 'error',
@ -180,6 +182,10 @@ module.exports = {
/* eslint-disable max-len, quotes */ /* eslint-disable max-len, quotes */
'no-restricted-syntax': [ 'no-restricted-syntax': [
'error', 'error',
{
selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",
message: "Please replace `assert.doesNotThrow()` and add a comment next to the code instead."
},
{ {
selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])`, selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])`,
message: 'use a regular expression for second argument of assert.throws()', message: 'use a regular expression for second argument of assert.throws()',
@ -204,6 +210,7 @@ module.exports = {
/* eslint-enable max-len, quotes */ /* eslint-enable max-len, quotes */
'no-tabs': 'error', 'no-tabs': 'error',
'no-trailing-spaces': 'error', 'no-trailing-spaces': 'error',
'no-unsafe-finally': 'error',
'object-curly-spacing': ['error', 'always'], 'object-curly-spacing': ['error', 'always'],
'one-var-declaration-per-line': 'error', 'one-var-declaration-per-line': 'error',
'operator-linebreak': ['error', 'after'], 'operator-linebreak': ['error', 'after'],