1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: favor assertions over console logging

Browse Source 
Communicate about leaked globals via `AssertionError` rather than
`console.log()`.

PR-URL: https://github.com/nodejs/node/pull/11547
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-02-24 22:18:25 -08:00 committed by James M Snell
parent 76a3e4984c
commit 12de99d982
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/common.js
View File

@ -402,8 +402,7 @@ process.on('exit', function() {
if (!exports.globalCheck) return; if (!exports.globalCheck) return;
const leaked = leakedGlobals(); const leaked = leakedGlobals();
if (leaked.length > 0) { if (leaked.length > 0) {
console.error('Unknown globals: %s', leaked); fail(`Unexpected global(s) found: ${leaked.join(', ')}`);
fail('Unknown global found');
} }
}); });