1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

util: skip type checks in internal getSystemErrorName

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/18546
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Joyee Cheung 2018-02-03 17:30:48 +08:00
parent bff5d5b8f0
commit 12ae33476a
No known key found for this signature in database
GPG Key ID: F586868AAD831D0C
2 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/internal/util.js
View File

@ -221,14 +221,6 @@ function getConstructorOf(obj) {
}
function getSystemErrorName(err) {
if (typeof err !== 'number') {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err', 'number', err);
}
if (err >= 0 || !Number.isSafeInteger(err)) {
throw new errors.RangeError('ERR_OUT_OF_RANGE', 'err',
'a negative integer', err);
}
const entry = errmap.get(err);
return entry ? entry[0] : `Unknown system error ${err}`;
}

13
lib/util.js
View File

@ -55,7 +55,7 @@ const {
const {
customInspectSymbol,
deprecate,
getSystemErrorName,
getSystemErrorName: internalErrorName,
getIdentificationOf,
isError,
promisify,
@ -1139,6 +1139,17 @@ function callbackify(original) {
return callbackified;
}
function getSystemErrorName(err) {
if (typeof err !== 'number') {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err', 'number', err);
}
if (err >= 0 || !Number.isSafeInteger(err)) {
throw new errors.RangeError('ERR_OUT_OF_RANGE', 'err',
'a negative integer', err);
}
return internalErrorName(err);
}
// Keep the `exports =` so that various functions can still be monkeypatched
module.exports = exports = {
_errnoException,