lint child_process.js

This commit is contained in:
Ryan Dahl 2010-12-01 16:56:03 -08:00
parent db78043d52
commit 11ea8da9c3

View File

@ -5,7 +5,7 @@ var InternalChildProcess = process.binding('child_process').ChildProcess;
var constants;
var spawn = exports.spawn = function (path, args /*, options OR env, customFds */) {
var spawn = exports.spawn = function(path, args /*, options, customFds */) {
var child = new ChildProcess();
child.spawn.apply(child, arguments);
return child;
@ -13,26 +13,25 @@ var spawn = exports.spawn = function (path, args /*, options OR env, customFds *
exports.exec = function(command /*, options, callback */) {
var _slice = Array.prototype.slice;
var args = ["/bin/sh", ["-c", command]].concat(_slice.call(arguments, 1));
return exports.execFile.apply(this, args)
var args = ['/bin/sh', ['-c', command]].concat(_slice.call(arguments, 1));
return exports.execFile.apply(this, args);
};
// execFile("something.sh", { env: ENV }, function() { })
// execFile('something.sh', { env: ENV }, function() { })
exports.execFile = function(file /* args, options, callback */) {
var options = { encoding: 'utf8'
, timeout: 0
, maxBuffer: 200*1024
, killSignal: 'SIGTERM'
, cwd: null
, env: null
};
var options = { encoding: 'utf8',
timeout: 0,
maxBuffer: 200 * 1024,
killSignal: 'SIGTERM',
cwd: null,
env: null };
var args, optionArg, callback;
// Parse the parameters.
if (typeof arguments[arguments.length-1] === "function") {
if (typeof arguments[arguments.length - 1] === 'function') {
callback = arguments[arguments.length - 1];
}
@ -54,8 +53,8 @@ exports.execFile = function (file /* args, options, callback */) {
}
var child = spawn(file, args, {cwd: options.cwd, env: options.env});
var stdout = "";
var stderr = "";
var stdout = '';
var stderr = '';
var killed = false;
var exited = false;
var timeoutId;
@ -74,7 +73,7 @@ exports.execFile = function (file /* args, options, callback */) {
if (code === 0 && signal === null) {
callback(null, stdout, stderr);
} else {
var e = new Error("Command failed: " + stderr);
var e = new Error('Command failed: ' + stderr);
e.killed = child.killed || killed;
e.code = code;
e.signal = signal;
@ -86,7 +85,7 @@ exports.execFile = function (file /* args, options, callback */) {
killed = true;
child.kill(options.killSignal);
process.nextTick(function() {
exithandler(null, options.killSignal)
exithandler(null, options.killSignal);
});
}
@ -100,21 +99,21 @@ exports.execFile = function (file /* args, options, callback */) {
child.stdout.setEncoding(options.encoding);
child.stderr.setEncoding(options.encoding);
child.stdout.addListener("data", function (chunk) {
child.stdout.addListener('data', function(chunk) {
stdout += chunk;
if (stdout.length > options.maxBuffer) {
kill();
}
});
child.stderr.addListener("data", function (chunk) {
child.stderr.addListener('data', function(chunk) {
stderr += chunk;
if (stderr.length > options.maxBuffer) {
kill();
}
});
child.addListener("exit", exithandler);
child.addListener('exit', exithandler);
return child;
};
@ -160,8 +159,8 @@ function ChildProcess () {
if (self.stdin) {
self.stdin.end();
}
if ( (!self.stdout || !self.stdout.readable)
&& (!self.stderr || !self.stderr.readable)) {
if ((!self.stdout || !self.stdout.readable) &&
(!self.stderr || !self.stderr.readable)) {
self.emit('exit', exitCode, termSignal);
}
};
@ -174,9 +173,9 @@ util.inherits(ChildProcess, EventEmitter);
ChildProcess.prototype.kill = function(sig) {
if (this._internal.pid) {
this.killed = true;
if (!constants) constants = process.binding("constants");
if (!constants) constants = process.binding('constants');
sig = sig || 'SIGTERM';
if (!constants[sig]) throw new Error("Unknown signal: " + sig);
if (!constants[sig]) throw new Error('Unknown signal: ' + sig);
return this._internal.kill(constants[sig]);
}
};
@ -190,12 +189,12 @@ ChildProcess.prototype.spawn = function (path, args, options, customFds) {
options.env === undefined &&
options.customFds === undefined) {
// Deprecated API: (path, args, options, env, customFds)
cwd = "";
cwd = '';
env = options || process.env;
customFds = customFds || [-1, -1, -1];
} else {
// Recommended API: (path, args, options)
cwd = options.cwd || "";
cwd = options.cwd || '';
env = options.env || process.env;
customFds = options.customFds || [-1, -1, -1];
}
@ -204,10 +203,11 @@ ChildProcess.prototype.spawn = function (path, args, options, customFds) {
var keys = Object.keys(env);
for (var index = 0, keysLength = keys.length; index < keysLength; index++) {
var key = keys[index];
envPairs.push(key + "=" + env[key]);
envPairs.push(key + '=' + env[key]);
}
var fds = this.fds = this._internal.spawn(path, args, cwd, envPairs, customFds);
var fds = this._internal.spawn(path, args, cwd, envPairs, customFds);
this.fds = fds;
if (customFds[0] === -1 || customFds[0] === undefined) {
this.stdin.open(fds[0]);