1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lint child_process.js

Browse Source
This commit is contained in:
Ryan Dahl 2010-12-01 16:56:03 -08:00
parent db78043d52
commit 11ea8da9c3
1 changed files with 42 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
lib/child_process.js
View File

@ -5,35 +5,34 @@ var InternalChildProcess = process.binding('child_process').ChildProcess;
var constants; var constants;
var spawn = exports.spawn = function (path, args /*, options OR env, customFds */) { var spawn = exports.spawn = function(path, args /*, options, customFds */) {
var child = new ChildProcess(); var child = new ChildProcess();
child.spawn.apply(child, arguments); child.spawn.apply(child, arguments);
return child; return child;
}; };
exports.exec = function (command /*, options, callback */) { exports.exec = function(command /*, options, callback */) {
var _slice = Array.prototype.slice; var _slice = Array.prototype.slice;
var args = ["/bin/sh", ["-c", command]].concat(_slice.call(arguments, 1)); var args = ['/bin/sh', ['-c', command]].concat(_slice.call(arguments, 1));
return exports.execFile.apply(this, args) return exports.execFile.apply(this, args);
}; };
// execFile("something.sh", { env: ENV }, function() { }) // execFile('something.sh', { env: ENV }, function() { })
exports.execFile = function (file /* args, options, callback */) { exports.execFile = function(file /* args, options, callback */) {
var options = { encoding: 'utf8' var options = { encoding: 'utf8',
, timeout: 0 timeout: 0,
, maxBuffer: 200*1024 maxBuffer: 200 * 1024,
, killSignal: 'SIGTERM' killSignal: 'SIGTERM',
, cwd: null cwd: null,
, env: null env: null };
};
var args, optionArg, callback; var args, optionArg, callback;
// Parse the parameters. // Parse the parameters.
if (typeof arguments[arguments.length-1] === "function") { if (typeof arguments[arguments.length - 1] === 'function') {
callback = arguments[arguments.length-1]; callback = arguments[arguments.length - 1];
} }
if (Array.isArray(arguments[1])) { if (Array.isArray(arguments[1])) {
@ -54,13 +53,13 @@ exports.execFile = function (file /* args, options, callback */) {
} }
var child = spawn(file, args, {cwd: options.cwd, env: options.env}); var child = spawn(file, args, {cwd: options.cwd, env: options.env});
var stdout = ""; var stdout = '';
var stderr = ""; var stderr = '';
var killed = false; var killed = false;
var exited = false; var exited = false;
var timeoutId; var timeoutId;
function exithandler (code, signal) { function exithandler(code, signal) {
if (exited) return; if (exited) return;
exited = true; exited = true;
@ -74,7 +73,7 @@ exports.execFile = function (file /* args, options, callback */) {
if (code === 0 && signal === null) { if (code === 0 && signal === null) {
callback(null, stdout, stderr); callback(null, stdout, stderr);
} else { } else {
var e = new Error("Command failed: " + stderr); var e = new Error('Command failed: ' + stderr);
e.killed = child.killed || killed; e.killed = child.killed || killed;
e.code = code; e.code = code;
e.signal = signal; e.signal = signal;
@ -82,16 +81,16 @@ exports.execFile = function (file /* args, options, callback */) {
} }
} }
function kill () { function kill() {
killed = true; killed = true;
child.kill(options.killSignal); child.kill(options.killSignal);
process.nextTick(function () { process.nextTick(function() {
exithandler(null, options.killSignal) exithandler(null, options.killSignal);
}); });
} }
if (options.timeout > 0) { if (options.timeout > 0) {
timeoutId = setTimeout(function () { timeoutId = setTimeout(function() {
kill(); kill();
timeoutId = null; timeoutId = null;
}, options.timeout); }, options.timeout);
@ -100,27 +99,27 @@ exports.execFile = function (file /* args, options, callback */) {
child.stdout.setEncoding(options.encoding); child.stdout.setEncoding(options.encoding);
child.stderr.setEncoding(options.encoding); child.stderr.setEncoding(options.encoding);
child.stdout.addListener("data", function (chunk) { child.stdout.addListener('data', function(chunk) {
stdout += chunk; stdout += chunk;
if (stdout.length > options.maxBuffer) { if (stdout.length > options.maxBuffer) {
kill(); kill();
} }
}); });
child.stderr.addListener("data", function (chunk) { child.stderr.addListener('data', function(chunk) {
stderr += chunk; stderr += chunk;
if (stderr.length > options.maxBuffer) { if (stderr.length > options.maxBuffer) {
kill(); kill();
} }
}); });
child.addListener("exit", exithandler); child.addListener('exit', exithandler);
return child; return child;
}; };
function ChildProcess () { function ChildProcess() {
EventEmitter.call(this); EventEmitter.call(this);
var self = this; var self = this;
@ -132,57 +131,57 @@ function ChildProcess () {
var termSignal; var termSignal;
var internal = this._internal = new InternalChildProcess(); var internal = this._internal = new InternalChildProcess();
var stdin = this.stdin = new Stream(); var stdin = this.stdin = new Stream();
var stdout = this.stdout = new Stream(); var stdout = this.stdout = new Stream();
var stderr = this.stderr = new Stream(); var stderr = this.stderr = new Stream();
var stderrClosed = false; var stderrClosed = false;
var stdoutClosed = false; var stdoutClosed = false;
stderr.addListener('close', function () { stderr.addListener('close', function() {
stderrClosed = true; stderrClosed = true;
if (gotCHLD && (!self.stdout || stdoutClosed)) { if (gotCHLD && (!self.stdout || stdoutClosed)) {
self.emit('exit', exitCode, termSignal); self.emit('exit', exitCode, termSignal);
} }
}); });
stdout.addListener('close', function () { stdout.addListener('close', function() {
stdoutClosed = true; stdoutClosed = true;
if (gotCHLD && (!self.stderr || stderrClosed)) { if (gotCHLD && (!self.stderr || stderrClosed)) {
self.emit('exit', exitCode, termSignal); self.emit('exit', exitCode, termSignal);
} }
}); });
internal.onexit = function (code, signal) { internal.onexit = function(code, signal) {
gotCHLD = true; gotCHLD = true;
exitCode = code; exitCode = code;
termSignal = signal; termSignal = signal;
if (self.stdin) { if (self.stdin) {
self.stdin.end(); self.stdin.end();
} }
if ( (!self.stdout || !self.stdout.readable) if ((!self.stdout || !self.stdout.readable) &&
&& (!self.stderr || !self.stderr.readable)) { (!self.stderr || !self.stderr.readable)) {
self.emit('exit', exitCode, termSignal); self.emit('exit', exitCode, termSignal);
} }
}; };
this.__defineGetter__('pid', function () { return internal.pid; }); this.__defineGetter__('pid', function() { return internal.pid; });
} }
util.inherits(ChildProcess, EventEmitter); util.inherits(ChildProcess, EventEmitter);
ChildProcess.prototype.kill = function (sig) { ChildProcess.prototype.kill = function(sig) {
if (this._internal.pid) { if (this._internal.pid) {
this.killed = true; this.killed = true;
if (!constants) constants = process.binding("constants"); if (!constants) constants = process.binding('constants');
sig = sig || 'SIGTERM'; sig = sig || 'SIGTERM';
if (!constants[sig]) throw new Error("Unknown signal: " + sig); if (!constants[sig]) throw new Error('Unknown signal: ' + sig);
return this._internal.kill(constants[sig]); return this._internal.kill(constants[sig]);
} }
}; };
ChildProcess.prototype.spawn = function (path, args, options, customFds) { ChildProcess.prototype.spawn = function(path, args, options, customFds) {
args = args || []; args = args || [];
var cwd, env; var cwd, env;
@ -190,12 +189,12 @@ ChildProcess.prototype.spawn = function (path, args, options, customFds) {
options.env === undefined && options.env === undefined &&
options.customFds === undefined) { options.customFds === undefined) {
// Deprecated API: (path, args, options, env, customFds) // Deprecated API: (path, args, options, env, customFds)
cwd = ""; cwd = '';
env = options || process.env; env = options || process.env;
customFds = customFds || [-1, -1, -1]; customFds = customFds || [-1, -1, -1];
} else { } else {
// Recommended API: (path, args, options) // Recommended API: (path, args, options)
cwd = options.cwd || ""; cwd = options.cwd || '';
env = options.env || process.env; env = options.env || process.env;
customFds = options.customFds || [-1, -1, -1]; customFds = options.customFds || [-1, -1, -1];
} }
@ -204,10 +203,11 @@ ChildProcess.prototype.spawn = function (path, args, options, customFds) {
var keys = Object.keys(env); var keys = Object.keys(env);
for (var index = 0, keysLength = keys.length; index < keysLength; index++) { for (var index = 0, keysLength = keys.length; index < keysLength; index++) {
var key = keys[index]; var key = keys[index];
envPairs.push(key + "=" + env[key]); envPairs.push(key + '=' + env[key]);
} }
var fds = this.fds = this._internal.spawn(path, args, cwd, envPairs, customFds); var fds = this._internal.spawn(path, args, cwd, envPairs, customFds);
this.fds = fds;
if (customFds[0] === -1 || customFds[0] === undefined) { if (customFds[0] === -1 || customFds[0] === undefined) {
this.stdin.open(fds[0]); this.stdin.open(fds[0]);