1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: remove obsolete function escapeHeaderValue

Browse Source 
There are test cases which validate the useful path of the function
never runs the functionality of it is obsoleted by
checkInvalidHeaderChar

PR-URL: https://github.com/nodejs/node/pull/24173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Lauri Piisang 2018-11-06 16:19:07 +00:00 committed by Gireesh Punathil
parent 6eda924c18
commit 117fef4558
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/_http_outgoing.js
View File

@ -409,7 +409,7 @@ function processHeader(self, state, key, value, validate) {
function storeHeader(self, state, key, value, validate) { function storeHeader(self, state, key, value, validate) {
if (validate) if (validate)
validateHeaderValue(key, value); validateHeaderValue(key, value);
state.header += key + ': ' + escapeHeaderValue(value) + CRLF; state.header += key + ': ' + value + CRLF;
matchHeader(self, state, key, value); matchHeader(self, state, key, value);
} }
@ -642,13 +642,6 @@ function connectionCorkNT(msg, conn) {
} }
function escapeHeaderValue(value) {
// Protect against response splitting. The regex test is there to
// minimize the performance impact in the common case.
return /[\r\n]/.test(value) ? value.replace(/[\r\n]+[ \t]*/g, '') : value;
}
OutgoingMessage.prototype.addTrailers = function addTrailers(headers) { OutgoingMessage.prototype.addTrailers = function addTrailers(headers) {
this._trailer = ''; this._trailer = '';
var keys = Object.keys(headers); var keys = Object.keys(headers);
@ -670,7 +663,7 @@ OutgoingMessage.prototype.addTrailers = function addTrailers(headers) {
debug('Trailer "%s" contains invalid characters', field); debug('Trailer "%s" contains invalid characters', field);
throw new ERR_INVALID_CHAR('trailer content', field); throw new ERR_INVALID_CHAR('trailer content', field);
} }
this._trailer += field + ': ' + escapeHeaderValue(value) + CRLF; this._trailer += field + ': ' + value + CRLF;
} }
}; };