1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: inherit JOBS from environment

Browse Source 
In some virtualized environments the amount of available resources
are misleading; for instance `multiprocessing.cpu_count()` on our current
4-core smartos vm's returns `48`. This is not a bug, merely how the vm
host provides information about available hardware.

Avoid running into issues by overriding `cpu_count()` with `JOBS`.

PR-URL: https://github.com/nodejs/node/pull/4495
Reviewed-By: Brian White <mscdex@mscdex.net>
This commit is contained in:
Johan Bergström 2015-12-31 17:32:42 +11:00
parent 242d07890f
commit 1170b26261
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/test.py
View File

@ -1339,7 +1339,10 @@ def ProcessOptions(options):
print "The test group to run (n) must be smaller than number of groups (m)." print "The test group to run (n) must be smaller than number of groups (m)."
return False return False
if options.J: if options.J:
options.j = multiprocessing.cpu_count() # inherit JOBS from environment if provided. some virtualised systems
# tends to exaggerate the number of available cpus/cores.
cores = os.environ.get('JOBS')
options.j = int(cores) if cores is not None else multiprocessing.cpu_count()
if options.flaky_tests not in ["run", "skip", "dontcare"]: if options.flaky_tests not in ["run", "skip", "dontcare"]:
print "Unknown flaky-tests mode %s" % options.flaky_tests print "Unknown flaky-tests mode %s" % options.flaky_tests
return False return False