net: don't emit listening if handle is closed
Fixes #7834 Signed-off-by: Trevor Norris <trev.norris@gmail.com>
This commit is contained in:
parent
613654e882
commit
1100f3de7a
@ -1136,6 +1136,8 @@ Server.prototype._listen2 = function(address, port, addressType, backlog, fd) {
|
|||||||
this._connectionKey = addressType + ':' + address + ':' + port;
|
this._connectionKey = addressType + ':' + address + ':' + port;
|
||||||
|
|
||||||
process.nextTick(function() {
|
process.nextTick(function() {
|
||||||
|
// ensure handle hasn't closed
|
||||||
|
if (self._handle)
|
||||||
self.emit('listening');
|
self.emit('listening');
|
||||||
});
|
});
|
||||||
};
|
};
|
||||||
|
36
test/simple/test-net-listen-close-server.js
Normal file
36
test/simple/test-net-listen-close-server.js
Normal file
@ -0,0 +1,36 @@
|
|||||||
|
// Copyright Joyent, Inc. and other Node contributors.
|
||||||
|
//
|
||||||
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
||||||
|
// copy of this software and associated documentation files (the
|
||||||
|
// "Software"), to deal in the Software without restriction, including
|
||||||
|
// without limitation the rights to use, copy, modify, merge, publish,
|
||||||
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
||||||
|
// persons to whom the Software is furnished to do so, subject to the
|
||||||
|
// following conditions:
|
||||||
|
//
|
||||||
|
// The above copyright notice and this permission notice shall be included
|
||||||
|
// in all copies or substantial portions of the Software.
|
||||||
|
//
|
||||||
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
||||||
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
||||||
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
||||||
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
||||||
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
||||||
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
||||||
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
||||||
|
|
||||||
|
var common = require('../common');
|
||||||
|
var assert = require('assert');
|
||||||
|
var net = require('net');
|
||||||
|
var gotError = false;
|
||||||
|
|
||||||
|
var server = net.createServer(function(socket) {
|
||||||
|
});
|
||||||
|
server.listen(common.PORT, function() {
|
||||||
|
assert(false);
|
||||||
|
});
|
||||||
|
server.on('error', function(error) {
|
||||||
|
common.debug(error);
|
||||||
|
assert(false);
|
||||||
|
});
|
||||||
|
server.close();
|
Loading…
x
Reference in New Issue
Block a user