process: triggerAsyncId can be undefined
Fixes: https://github.com/nodejs/node/issues/14386 Fixes: https://github.com/nodejs/node/issues/14381 PR-URL: https://github.com/nodejs/node/pull/14387 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This commit is contained in:
parent
43e105f645
commit
107db33fb9
@ -281,7 +281,7 @@ function setupNextTick() {
|
|||||||
if (process._exiting)
|
if (process._exiting)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
if (triggerAsyncId === null) {
|
if (!Number.isSafeInteger(triggerAsyncId) || triggerAsyncId <= 0) {
|
||||||
triggerAsyncId = async_hooks.initTriggerId();
|
triggerAsyncId = async_hooks.initTriggerId();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -26,6 +26,11 @@ internal.nextTick(null, common.mustCall(function() {
|
|||||||
assert.strictEqual(async_hooks.triggerAsyncId(), rootAsyncId);
|
assert.strictEqual(async_hooks.triggerAsyncId(), rootAsyncId);
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
// internal default
|
||||||
|
internal.nextTick(undefined, common.mustCall(function() {
|
||||||
|
assert.strictEqual(async_hooks.triggerAsyncId(), rootAsyncId);
|
||||||
|
}));
|
||||||
|
|
||||||
// internal
|
// internal
|
||||||
internal.nextTick(rootAsyncId + 1, common.mustCall(function() {
|
internal.nextTick(rootAsyncId + 1, common.mustCall(function() {
|
||||||
assert.strictEqual(async_hooks.triggerAsyncId(), rootAsyncId + 1);
|
assert.strictEqual(async_hooks.triggerAsyncId(), rootAsyncId + 1);
|
||||||
|
32
test/parallel/test-http-outgoing-message-inheritance.js
Normal file
32
test/parallel/test-http-outgoing-message-inheritance.js
Normal file
@ -0,0 +1,32 @@
|
|||||||
|
'use strict';
|
||||||
|
|
||||||
|
const common = require('../common');
|
||||||
|
const { OutgoingMessage } = require('http');
|
||||||
|
const { Writable } = require('stream');
|
||||||
|
const assert = require('assert');
|
||||||
|
|
||||||
|
// check that OutgoingMessage can be used without a proper Socket
|
||||||
|
// Fixes: https://github.com/nodejs/node/issues/14386
|
||||||
|
// Fixes: https://github.com/nodejs/node/issues/14381
|
||||||
|
|
||||||
|
class Response extends OutgoingMessage {
|
||||||
|
constructor() {
|
||||||
|
super({ method: 'GET', httpVersionMajor: 1, httpVersionMinor: 1 });
|
||||||
|
}
|
||||||
|
|
||||||
|
_implicitHeader() {}
|
||||||
|
}
|
||||||
|
|
||||||
|
const res = new Response();
|
||||||
|
const ws = new Writable({
|
||||||
|
write: common.mustCall((chunk, encoding, callback) => {
|
||||||
|
assert(chunk.toString().match(/hello world/));
|
||||||
|
setImmediate(callback);
|
||||||
|
})
|
||||||
|
});
|
||||||
|
|
||||||
|
res.socket = ws;
|
||||||
|
ws._httpMessage = res;
|
||||||
|
res.connection = ws;
|
||||||
|
|
||||||
|
res.end('hello world');
|
27
test/parallel/test-http-server-response-standalone.js
Normal file
27
test/parallel/test-http-server-response-standalone.js
Normal file
@ -0,0 +1,27 @@
|
|||||||
|
'use strict';
|
||||||
|
|
||||||
|
const common = require('../common');
|
||||||
|
const { ServerResponse } = require('http');
|
||||||
|
const { Writable } = require('stream');
|
||||||
|
const assert = require('assert');
|
||||||
|
|
||||||
|
// check that ServerResponse can be used without a proper Socket
|
||||||
|
// Fixes: https://github.com/nodejs/node/issues/14386
|
||||||
|
// Fixes: https://github.com/nodejs/node/issues/14381
|
||||||
|
|
||||||
|
const res = new ServerResponse({
|
||||||
|
method: 'GET',
|
||||||
|
httpVersionMajor: 1,
|
||||||
|
httpVersionMinor: 1
|
||||||
|
});
|
||||||
|
|
||||||
|
const ws = new Writable({
|
||||||
|
write: common.mustCall((chunk, encoding, callback) => {
|
||||||
|
assert(chunk.toString().match(/hello world/));
|
||||||
|
setImmediate(callback);
|
||||||
|
})
|
||||||
|
});
|
||||||
|
|
||||||
|
res.assignSocket(ws);
|
||||||
|
|
||||||
|
res.end('hello world');
|
Loading…
x
Reference in New Issue
Block a user