1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: check fd 0,1,2 are used, not access mode

Browse Source 
Don't do a write on stdout/stderr because that checks for their
writability. But fd=1 could legitimately be opened with read-only
access by the user. All this test needs to ensure is that
they are used at startup.

PR-URL: https://github.com/nodejs/node/pull/10339
Fixes: https://github.com/nodejs/node/issues/10234
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
John Barboza 2016-12-16 10:46:20 -05:00 committed by Gibson Fahnestock
parent 87039e307e
commit 106d09ab7a
1 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/parallel/test-stdio-closed.js
View File

@ -2,6 +2,7 @@
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
const fs = require('fs');
if (common.isWindows) { if (common.isWindows) {
common.skip('platform not supported.'); common.skip('platform not supported.');
@ -9,21 +10,7 @@ if (common.isWindows) {
} }
if (process.argv[2] === 'child') { if (process.argv[2] === 'child') {
try { [0, 1, 2].forEach((i) => assert.doesNotThrow(() => fs.fstatSync(i)));
process.stdout.write('stdout', function() {
try {
process.stderr.write('stderr', function() {
process.exit(42);
});
} catch (e) {
process.exit(84);
}
});
} catch (e) {
assert.strictEqual(e.code, 'EBADF');
assert.strictEqual(e.message, 'EBADF: bad file descriptor, write');
process.exit(126);
}
return; return;
} }
@ -32,5 +19,5 @@ const cmd = `"${process.execPath}" "${__filename}" child 1>&- 2>&-`;
const proc = spawn('/bin/sh', ['-c', cmd], { stdio: 'inherit' }); const proc = spawn('/bin/sh', ['-c', cmd], { stdio: 'inherit' });
proc.on('exit', common.mustCall(function(exitCode) { proc.on('exit', common.mustCall(function(exitCode) {
assert.strictEqual(exitCode, common.isAix ? 126 : 42); assert.strictEqual(exitCode, 0);
})); }));