1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

crypto: set DEFAULT_ENCODING property to non-enumerable

Browse Source 
Since it is a deprecated API, a deprecation warning is printed when
loading crypto module from ESM. Making it non enumerable remove the
deprecation warning and make the API non-available to named imports.

PR-URL: https://github.com/nodejs/node/pull/23222
Fixes: https://github.com/nodejs/node/issues/23203
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
Antoine du Hamel 2018-10-02 19:12:32 +02:00 committed by guybedford
parent 5850220229
commit 0f63d84f80
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/crypto.js
View File

@ -230,7 +230,7 @@ Object.defineProperties(exports, {
fipsForced ? setFipsForced : setFipsCrypto fipsForced ? setFipsForced : setFipsCrypto
}, },
DEFAULT_ENCODING: { DEFAULT_ENCODING: {
enumerable: true, enumerable: false,
configurable: true, configurable: true,
get: deprecate(getDefaultEncoding, get: deprecate(getDefaultEncoding,
'crypto.DEFAULT_ENCODING is deprecated.', 'DEP0091'), 'crypto.DEFAULT_ENCODING is deprecated.', 'DEP0091'),