1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactored test-http-response-splitting to use countdown

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17348
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Mithun Sasidharan 2017-11-27 16:33:26 +05:30 committed by Anna Henningsen
parent 5282f969c0
commit 0f3fd79ee9
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/parallel/test-http-response-splitting.js
View File

@ -5,6 +5,7 @@ const http = require('http');
const net = require('net'); const net = require('net');
const url = require('url'); const url = require('url');
const assert = require('assert'); const assert = require('assert');
const Countdown = require('../common/countdown');
// Response splitting example, credit: Amit Klein, Safebreach // Response splitting example, credit: Amit Klein, Safebreach
const str = '/welcome?lang=bar%c4%8d%c4%8aContent­Length:%200%c4%8d%c4%8a%c' + const str = '/welcome?lang=bar%c4%8d%c4%8aContent­Length:%200%c4%8d%c4%8a%c' +
@ -18,6 +19,7 @@ const x = 'fooഊSet-Cookie: foo=barഊഊ<script>alert("Hi!")</script>';
const y = 'foo⠊Set-Cookie: foo=bar'; const y = 'foo⠊Set-Cookie: foo=bar';
let count = 0; let count = 0;
const countdown = new Countdown(3, () => server.close());
function test(res, code, key, value) { function test(res, code, key, value) {
const header = { [key]: value }; const header = { [key]: value };
@ -46,8 +48,7 @@ const server = http.createServer((req, res) => {
default: default:
assert.fail('should not get to here.'); assert.fail('should not get to here.');
} }
if (count === 3) countdown.dec();
server.close();
res.end('ok'); res.end('ok');
}); });
server.listen(0, () => { server.listen(0, () => {