test: refactor to block-scope

PR-URL: https://github.com/nodejs/node/pull/25532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
LakshmiSwethaG 2019-01-16 05:24:43 -05:00 committed by Anna Henningsen
parent 62942e9ad7
commit 0f0e7f55f8
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9

View File

@ -42,36 +42,45 @@ function unregisterWatcher(watcher) {
}
}
const watcher1 = fs.watch(
tmpdir.path,
{ encoding: 'hex' },
(event, filename) => {
if (['e696b0e5bbbae69687e5a4b9e4bbb62e747874', null].includes(filename))
done(watcher1);
}
);
registerWatcher(watcher1);
{
// Test that using the `encoding` option has the expected result.
const watcher = fs.watch(
tmpdir.path,
{ encoding: 'hex' },
(event, filename) => {
if (['e696b0e5bbbae69687e5a4b9e4bbb62e747874', null].includes(filename))
done(watcher);
}
);
registerWatcher(watcher);
}
const watcher2 = fs.watch(
tmpdir.path,
(event, filename) => {
if ([fn, null].includes(filename))
done(watcher2);
}
);
registerWatcher(watcher2);
{
// Test that in absence of `encoding` option has the expected result.
const watcher = fs.watch(
tmpdir.path,
(event, filename) => {
if ([fn, null].includes(filename))
done(watcher);
}
);
registerWatcher(watcher);
}
const watcher3 = fs.watch(
tmpdir.path,
{ encoding: 'buffer' },
(event, filename) => {
if (filename instanceof Buffer && filename.toString('utf8') === fn)
done(watcher3);
else if (filename === null)
done(watcher3);
}
);
registerWatcher(watcher3);
{
// Test that using the `encoding` option has the expected result.
const watcher = fs.watch(
tmpdir.path,
{ encoding: 'buffer' },
(event, filename) => {
if (filename instanceof Buffer && filename.toString('utf8') === fn)
done(watcher);
else if (filename === null)
done(watcher);
}
);
registerWatcher(watcher);
}
const done = common.mustCall(unregisterWatcher, watchers.size);