1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add promise API test for appendFile()

Browse Source 
Apply the first of five test cases in test-fs-append-file to the
promise-based API in addition to the callback-based API.

PR-URL: https://github.com/nodejs/node/pull/20739
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Rich Trott 2018-05-14 21:02:32 -07:00
parent 8630eea171
commit 0d9500daed
1 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
test/parallel/test-fs-append-file.js
View File

@ -27,8 +27,6 @@ const join = require('path').join;
const tmpdir = require('../common/tmpdir'); const tmpdir = require('../common/tmpdir');
const filename = join(tmpdir.path, 'append.txt');
const currentFileData = 'ABCD'; const currentFileData = 'ABCD';
const n = 220; const n = 220;
@ -44,18 +42,33 @@ let ncallbacks = 0;
tmpdir.refresh(); tmpdir.refresh();
// test that empty file will be created and have content added const throwNextTick = (e) => { process.nextTick(() => { throw e; }); };
fs.appendFile(filename, s, function(e) {
// test that empty file will be created and have content added (callback API)
{
const filename = join(tmpdir.path, 'append.txt');
fs.appendFile(filename, s, common.mustCall(function(e) {
assert.ifError(e); assert.ifError(e);
ncallbacks++; fs.readFile(filename, common.mustCall(function(e, buffer) {
fs.readFile(filename, function(e, buffer) {
assert.ifError(e); assert.ifError(e);
ncallbacks++;
assert.strictEqual(Buffer.byteLength(s), buffer.length); assert.strictEqual(Buffer.byteLength(s), buffer.length);
}); }));
}); }));
}
// test that empty file will be created and have content added (promise API)
{
const filename = join(tmpdir.path, 'append-promise.txt');
fs.promises.appendFile(filename, s)
.then(common.mustCall(() => fs.promises.readFile(filename)))
.then((buffer) => {
assert.strictEqual(Buffer.byteLength(s), buffer.length);
})
.catch(throwNextTick);
}
// test that appends data to a non empty file // test that appends data to a non empty file
const filename2 = join(tmpdir.path, 'append2.txt'); const filename2 = join(tmpdir.path, 'append2.txt');
@ -151,9 +164,8 @@ assert.throws(
{ code: 'ERR_INVALID_CALLBACK' }); { code: 'ERR_INVALID_CALLBACK' });
process.on('exit', function() { process.on('exit', function() {
assert.strictEqual(12, ncallbacks); assert.strictEqual(10, ncallbacks);
fs.unlinkSync(filename);
fs.unlinkSync(filename2); fs.unlinkSync(filename2);
fs.unlinkSync(filename3); fs.unlinkSync(filename3);
fs.unlinkSync(filename4); fs.unlinkSync(filename4);