benchmark: swap var for let in url benchmarks
In benchmark url directory this changes for loops using var to let when it applies for consistency PR-URL: https://github.com/nodejs/node/pull/28867 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
parent
3d56e89c8a
commit
0d1b14ac19
@ -26,7 +26,7 @@ function useLegacy(data) {
|
|||||||
// It's necessary to assign the values to an object
|
// It's necessary to assign the values to an object
|
||||||
// to avoid loop invariant code motion.
|
// to avoid loop invariant code motion.
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < len; i++) {
|
for (let i = 0; i < len; i++) {
|
||||||
const obj = data[i];
|
const obj = data[i];
|
||||||
noDead.protocol = obj.protocol;
|
noDead.protocol = obj.protocol;
|
||||||
noDead.auth = obj.auth;
|
noDead.auth = obj.auth;
|
||||||
@ -55,7 +55,7 @@ function useWHATWG(data) {
|
|||||||
};
|
};
|
||||||
const len = data.length;
|
const len = data.length;
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < len; i++) {
|
for (let i = 0; i < len; i++) {
|
||||||
const obj = data[i];
|
const obj = data[i];
|
||||||
noDead.protocol = obj.protocol;
|
noDead.protocol = obj.protocol;
|
||||||
noDead.auth = `${obj.username}:${obj.password}`;
|
noDead.auth = `${obj.username}:${obj.password}`;
|
||||||
|
@ -15,7 +15,7 @@ function useLegacy(data) {
|
|||||||
const len = data.length;
|
const len = data.length;
|
||||||
var result = url.parse(data[0]); // Avoid dead code elimination
|
var result = url.parse(data[0]); // Avoid dead code elimination
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < len; ++i) {
|
for (let i = 0; i < len; ++i) {
|
||||||
result = url.parse(data[i]);
|
result = url.parse(data[i]);
|
||||||
}
|
}
|
||||||
bench.end(len);
|
bench.end(len);
|
||||||
@ -26,7 +26,7 @@ function useWHATWGWithBase(data) {
|
|||||||
const len = data.length;
|
const len = data.length;
|
||||||
var result = new URL(data[0][0], data[0][1]); // Avoid dead code elimination
|
var result = new URL(data[0][0], data[0][1]); // Avoid dead code elimination
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < len; ++i) {
|
for (let i = 0; i < len; ++i) {
|
||||||
const item = data[i];
|
const item = data[i];
|
||||||
result = new URL(item[0], item[1]);
|
result = new URL(item[0], item[1]);
|
||||||
}
|
}
|
||||||
@ -38,7 +38,7 @@ function useWHATWGWithoutBase(data) {
|
|||||||
const len = data.length;
|
const len = data.length;
|
||||||
var result = new URL(data[0]); // Avoid dead code elimination
|
var result = new URL(data[0]); // Avoid dead code elimination
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < len; ++i) {
|
for (let i = 0; i < len; ++i) {
|
||||||
result = new URL(data[i]);
|
result = new URL(data[i]);
|
||||||
}
|
}
|
||||||
bench.end(len);
|
bench.end(len);
|
||||||
|
@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
|
|||||||
function useLegacy(n, input) {
|
function useLegacy(n, input) {
|
||||||
querystring.parse(input);
|
querystring.parse(input);
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1) {
|
for (let i = 0; i < n; i += 1) {
|
||||||
querystring.parse(input);
|
querystring.parse(input);
|
||||||
}
|
}
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
@ -22,7 +22,7 @@ function useLegacy(n, input) {
|
|||||||
function useWHATWG(n, param) {
|
function useWHATWG(n, param) {
|
||||||
new URLSearchParams(param);
|
new URLSearchParams(param);
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1) {
|
for (let i = 0; i < n; i += 1) {
|
||||||
new URLSearchParams(param);
|
new URLSearchParams(param);
|
||||||
}
|
}
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
|
@ -14,7 +14,7 @@ function useLegacy(n, input, prop) {
|
|||||||
const obj = querystring.parse(input);
|
const obj = querystring.parse(input);
|
||||||
querystring.stringify(obj);
|
querystring.stringify(obj);
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1) {
|
for (let i = 0; i < n; i += 1) {
|
||||||
querystring.stringify(obj);
|
querystring.stringify(obj);
|
||||||
}
|
}
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
@ -24,7 +24,7 @@ function useWHATWG(n, param, prop) {
|
|||||||
const obj = new URLSearchParams(param);
|
const obj = new URLSearchParams(param);
|
||||||
obj.toString();
|
obj.toString();
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1) {
|
for (let i = 0; i < n; i += 1) {
|
||||||
obj.toString();
|
obj.toString();
|
||||||
}
|
}
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
|
@ -15,7 +15,7 @@ function useLegacy(data) {
|
|||||||
const len = data.length;
|
const len = data.length;
|
||||||
var noDead = url.format(obj);
|
var noDead = url.format(obj);
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < len; i++) {
|
for (let i = 0; i < len; i++) {
|
||||||
noDead = data[i].toString();
|
noDead = data[i].toString();
|
||||||
}
|
}
|
||||||
bench.end(len);
|
bench.end(len);
|
||||||
@ -27,7 +27,7 @@ function useWHATWG(data) {
|
|||||||
const len = data.length;
|
const len = data.length;
|
||||||
var noDead = obj.toString();
|
var noDead = obj.toString();
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < len; i++) {
|
for (let i = 0; i < len; i++) {
|
||||||
noDead = data[i].toString();
|
noDead = data[i].toString();
|
||||||
}
|
}
|
||||||
bench.end(len);
|
bench.end(len);
|
||||||
|
@ -21,7 +21,7 @@ function main({ type, n }) {
|
|||||||
url.format(inputs[name]);
|
url.format(inputs[name]);
|
||||||
|
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1)
|
for (let i = 0; i < n; i += 1)
|
||||||
url.format(input);
|
url.format(input);
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
}
|
}
|
||||||
|
@ -16,7 +16,7 @@ function main({ type, n }) {
|
|||||||
const input = inputs[type] || '';
|
const input = inputs[type] || '';
|
||||||
|
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1)
|
for (let i = 0; i < n; i += 1)
|
||||||
url.parse(input);
|
url.parse(input);
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
}
|
}
|
||||||
|
@ -23,7 +23,7 @@ function main({ n, href, path }) {
|
|||||||
const p = paths[path];
|
const p = paths[path];
|
||||||
|
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1)
|
for (let i = 0; i < n; i += 1)
|
||||||
url.resolve(h, p);
|
url.resolve(h, p);
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
}
|
}
|
||||||
|
@ -19,7 +19,7 @@ function forEach(n) {
|
|||||||
};
|
};
|
||||||
|
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1)
|
for (let i = 0; i < n; i += 1)
|
||||||
params.forEach(cb);
|
params.forEach(cb);
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
|
|
||||||
@ -32,7 +32,7 @@ function iterator(n) {
|
|||||||
const noDead = [];
|
const noDead = [];
|
||||||
|
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1) {
|
for (let i = 0; i < n; i += 1) {
|
||||||
for (const pair of params) {
|
for (const pair of params) {
|
||||||
noDead[0] = pair[0];
|
noDead[0] = pair[0];
|
||||||
noDead[1] = pair[1];
|
noDead[1] = pair[1];
|
||||||
|
@ -16,7 +16,7 @@ function main({ accessMethod, param, n }) {
|
|||||||
throw new Error(`Unknown method ${accessMethod}`);
|
throw new Error(`Unknown method ${accessMethod}`);
|
||||||
|
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i += 1)
|
for (let i = 0; i < n; i += 1)
|
||||||
params[accessMethod](param);
|
params[accessMethod](param);
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
}
|
}
|
||||||
|
@ -39,7 +39,7 @@ function main({ type, n }) {
|
|||||||
const array = getParams(input);
|
const array = getParams(input);
|
||||||
|
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i++) {
|
for (let i = 0; i < n; i++) {
|
||||||
params[searchParams] = array.slice();
|
params[searchParams] = array.slice();
|
||||||
params.sort();
|
params.sort();
|
||||||
}
|
}
|
||||||
|
@ -21,7 +21,7 @@ function main({ input, n }) {
|
|||||||
const str = inputs[input];
|
const str = inputs[input];
|
||||||
|
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i++)
|
for (let i = 0; i < n; i++)
|
||||||
toUSVString(str);
|
toUSVString(str);
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
}
|
}
|
||||||
|
@ -36,7 +36,7 @@ function main({ n, to, domain }) {
|
|||||||
const method = to === 'ascii' ? domainToASCII : domainToUnicode;
|
const method = to === 'ascii' ? domainToASCII : domainToUnicode;
|
||||||
|
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < n; i++) {
|
for (let i = 0; i < n; i++) {
|
||||||
method(value);
|
method(value);
|
||||||
}
|
}
|
||||||
bench.end(n);
|
bench.end(n);
|
||||||
|
@ -14,7 +14,7 @@ function setAndGet(data, prop) {
|
|||||||
const len = data.length;
|
const len = data.length;
|
||||||
var result = data[0][prop];
|
var result = data[0][prop];
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < len; ++i) {
|
for (let i = 0; i < len; ++i) {
|
||||||
result = data[i][prop];
|
result = data[i][prop];
|
||||||
data[i][prop] = result;
|
data[i][prop] = result;
|
||||||
}
|
}
|
||||||
@ -26,7 +26,7 @@ function get(data, prop) {
|
|||||||
const len = data.length;
|
const len = data.length;
|
||||||
var result = data[0][prop];
|
var result = data[0][prop];
|
||||||
bench.start();
|
bench.start();
|
||||||
for (var i = 0; i < len; ++i) {
|
for (let i = 0; i < len; ++i) {
|
||||||
result = data[i][prop]; // get
|
result = data[i][prop]; // get
|
||||||
}
|
}
|
||||||
bench.end(len);
|
bench.end(len);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user