From 0d000ca51f4c274a4786f28019032eca9b74146f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 21 Mar 2017 17:07:23 -0700 Subject: [PATCH] test: add minimal test for net benchmarks Currently, benchmark code is not exercised at all in CI. This adds a minimal test for net benchmarks. If this is deemed acceptable, similar minimal tests for other benchmarks can be written. Additionally, as issues and edge cases are uncovered, checks for them can be added. PR-URL: https://github.com/nodejs/node/pull/11979 Reviewed-By: James M Snell Reviewed-By: Joyee Cheung --- test/sequential/test-benchmark-net.js | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 test/sequential/test-benchmark-net.js diff --git a/test/sequential/test-benchmark-net.js b/test/sequential/test-benchmark-net.js new file mode 100644 index 00000000000..4bb91451e9b --- /dev/null +++ b/test/sequential/test-benchmark-net.js @@ -0,0 +1,22 @@ +'use strict'; + +require('../common'); + +// Minimal test for net benchmarks. This makes sure the benchmarks aren't +// horribly broken but nothing more than that. + +// Because the net benchmarks use hardcoded ports, this should be in sequential +// rather than parallel to make sure it does not conflict with tests that choose +// random available ports. + +const assert = require('assert'); +const fork = require('child_process').fork; +const path = require('path'); + +const runjs = path.join(__dirname, '..', '..', 'benchmark', 'run.js'); + +const child = fork(runjs, ['--set', 'dur=0', 'net']); +child.on('exit', (code, signal) => { + assert.strictEqual(code, 0); + assert.strictEqual(signal, null); +});