1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fixed flaky test-net-connect-local-error

Browse Source 
Fixed test-net-connect-local-error by moving the test from
parallel to sequential.

PR-URL: https://github.com/nodejs/node/pull/12964
Fixes: https://github.com/nodejs/node/issues/12950
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Sebastian Plesciuc 2017-05-15 20:19:43 +03:00 committed by Refael Ackermann
parent 008301167e
commit 0c2edd27e6
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/parallel/test-net-connect-local-error.js → test/sequential/test-net-connect-local-error.js
View File

@ -3,25 +3,28 @@ const common = require('../common');
const assert = require('assert');
const net = require('net');
const server = net.createServer();
server.listen(0);
const port = server.address().port;
const client = net.connect({
port: port + 1,
localPort: port,
port: common.PORT + 1,
localPort: common.PORT,
localAddress: common.localhostIPv4
});
client.on('error', common.mustCall(function onError(err) {
assert.strictEqual(err.syscall, 'connect');
assert.strictEqual(err.code, 'ECONNREFUSED');
assert.strictEqual(
err.localPort,
port,
`${err.localPort} !== ${port} in ${err}`
common.PORT,
`${err.localPort} !== ${common.PORT} in ${err}`
);
assert.strictEqual(
err.localAddress,
common.localhostIPv4,
`${err.localAddress} !== ${common.localhostIPv4} in ${err}`
);
assert.strictEqual(
err.message,
`connect ECONNREFUSED ${err.address}:${err.port} ` +
`- Local (${err.localAddress}:${err.localPort})`
);
}));
server.close();