1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

util: use Set to store deprecation codes

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/28113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Daniel Nalborczyk 2019-06-06 17:08:00 -04:00 committed by Rich Trott
parent 7105bbc710
commit 0c1fd20693
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/internal/util.js
View File

@ -35,7 +35,7 @@ function isError(e) {
// Keep a list of deprecation codes that have been warned on so we only warn on // Keep a list of deprecation codes that have been warned on so we only warn on
// each one once. // each one once.
const codesWarned = {}; const codesWarned = new Set();
// Mark that a method should not be used. // Mark that a method should not be used.
// Returns a modified function which warns once by default. // Returns a modified function which warns once by default.
@ -53,9 +53,9 @@ function deprecate(fn, msg, code) {
if (!warned) { if (!warned) {
warned = true; warned = true;
if (code !== undefined) { if (code !== undefined) {
if (!codesWarned[code]) { if (!codesWarned.has(code)) {
process.emitWarning(msg, 'DeprecationWarning', code, deprecated); process.emitWarning(msg, 'DeprecationWarning', code, deprecated);
codesWarned[code] = true; codesWarned.add(code);
} }
} else { } else {
process.emitWarning(msg, 'DeprecationWarning', deprecated); process.emitWarning(msg, 'DeprecationWarning', deprecated);