From 0bff955b6d9e1d3f5b1c0b1b71e68f7c0da33de7 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Sun, 25 Feb 2018 03:07:56 +0800 Subject: [PATCH] build: fix lint-md-build dependency MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/18981 Fixes: https://github.com/nodejs/node/issues/18978 Reviewed-By: Gus Caplan Reviewed-By: Сковорода Никита Андреевич Reviewed-By: Daijiro Wachi Reviewed-By: James M Snell --- Makefile | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index d5a8d1e2675..ccb53f0de0f 100644 --- a/Makefile +++ b/Makefile @@ -1056,15 +1056,18 @@ lint-md-clean: $(RM) -r tools/remark-preset-lint-node/node_modules $(RM) tools/.*mdlintstamp -.PHONY: lint-md-build -lint-md-build: - @if [ ! -d tools/remark-cli/node_modules ]; then \ - echo "Markdown linter: installing remark-cli into tools/"; \ - cd tools/remark-cli && $(call available-node,$(run-npm-install)) fi - @if [ ! -d tools/remark-preset-lint-node/node_modules ]; then \ - echo "Markdown linter: installing remark-preset-lint-node into tools/"; \ - cd tools/remark-preset-lint-node && $(call available-node,$(run-npm-install)) fi +tools/remark-cli/node_modules: tools/remark-cli/package.json + @echo "Markdown linter: installing remark-cli into tools/" + @cd tools/remark-cli && $(call available-node,$(run-npm-install)) +tools/remark-preset-lint-node/node_modules: \ + tools/remark-preset-lint-node/package.json + @echo "Markdown linter: installing remark-preset-lint-node into tools/" + @cd tools/remark-preset-lint-node && $(call available-node,$(run-npm-install)) + +.PHONY: lint-md-build +lint-md-build: tools/remark-cli/node_modules \ + tools/remark-preset-lint-node/node_modules .PHONY: lint-md ifneq ("","$(wildcard tools/remark-cli/node_modules/)")