1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: check arg type for dnsPromises.resolve

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/22000
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Masashi Hirano 2018-07-27 08:11:04 +09:00 committed by Trivikram Kamat
parent a4c1cf5f86
commit 0b85435c01
1 changed files with 25 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
test/parallel/test-dns.js
View File

@ -135,14 +135,31 @@ assert.deepStrictEqual(dns.getServers(), portsExpected);
dns.setServers([]); dns.setServers([]);
assert.deepStrictEqual(dns.getServers(), []); assert.deepStrictEqual(dns.getServers(), []);
common.expectsError(() => { {
dns.resolve('example.com', [], common.mustNotCall()); const errObj = {
}, {
code: 'ERR_INVALID_ARG_TYPE', code: 'ERR_INVALID_ARG_TYPE',
type: TypeError, type: TypeError,
message: 'The "rrtype" argument must be of type string. ' + message: 'The "rrtype" argument must be of type string. ' +
'Received type object' 'Received type object'
}); };
common.expectsError(() => {
dns.resolve('example.com', [], common.mustNotCall());
}, errObj);
common.expectsError(() => {
dnsPromises.resolve('example.com', []);
}, errObj);
}
{
const errObj = {
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "name" argument must be of type string. ' +
'Received type undefined'
};
common.expectsError(() => {
dnsPromises.resolve();
}, errObj);
}
// dns.lookup should accept only falsey and string values // dns.lookup should accept only falsey and string values
{ {