1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: fix -Warray-bounds warning

Browse Source 
Avoid out of bounds access to `url_host_value.ipv6` array.

PR-URL: https://github.com/nodejs/node/pull/9751
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Santiago Gimeno 2016-11-22 14:47:11 +01:00
parent 11b087222b
commit 0ab2182199
No known key found for this signature in database
GPG Key ID: F28C3C8DA33C03BE
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/node_url.cc
View File

@ -472,10 +472,8 @@ namespace url {
uint16_t* piece = &host->value.ipv6[n]; uint16_t* piece = &host->value.ipv6[n];
if (compress_pointer == piece) { if (compress_pointer == piece) {
*dest += n == 0 ? "::" : ":"; *dest += n == 0 ? "::" : ":";
while (*piece == 0 && n < 8) { while (*piece == 0 && ++n < 8)
n++;
piece = &host->value.ipv6[n]; piece = &host->value.ipv6[n];
}
if (n == 8) if (n == 8)
break; break;
} }