1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http2: add checks for server close callback

Browse Source 
Verify that server close callbacks are being called

PR-URL: https://github.com/nodejs/node/pull/18182
Refs: https://github.com/nodejs/node/issues/18176
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
James M Snell 2018-01-16 09:34:20 -08:00 committed by Ruben Bridgewater
parent 2a61ce5996
commit 0a1adc061e
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
4 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/parallel/test-http2-create-client-secure-session.js
View File

@ -38,6 +38,7 @@ function onStream(stream, headers) {
function verifySecureSession(key, cert, ca, opts) {
const server = h2.createSecureServer({ cert, key });
server.on('stream', common.mustCall(onStream));
server.on('close', common.mustCall());
server.listen(0, common.mustCall(() => {
opts = opts || { };
opts.secureContext = tls.createSecureContext({ ca });
@ -72,7 +73,7 @@ function verifySecureSession(key, cert, ca, opts) {
assert.strictEqual(jsonData.servername,
opts.servername || 'localhost');
assert.strictEqual(jsonData.alpnProtocol, 'h2');
server.close();
server.close(common.mustCall());
client[kSocket].destroy();
}));
}));

4
test/parallel/test-http2-create-client-session.js
View File

@ -29,6 +29,8 @@ function onStream(stream, headers, flags) {
stream.end(body.slice(20));
}
server.on('close', common.mustCall());
server.listen(0);
server.on('listening', common.mustCall(() => {
@ -46,7 +48,7 @@ server.on('listening', common.mustCall(() => {
const countdown = new Countdown(count, () => {
client.close();
server.close();
server.close(common.mustCall());
});
for (let n = 0; n < count; n++) {

2
test/parallel/test-http2-createwritereq.js
View File

@ -60,7 +60,7 @@ server.listen(0, common.mustCall(function() {
testsFinished++;
if (testsFinished === testsToRun) {
server.close();
server.close(common.mustCall());
}
}));

4
test/parallel/test-http2-misbehaving-flow-control.js
View File

@ -72,7 +72,7 @@ server.on('stream', (stream) => {
message: 'Stream closed with error code 3'
}));
stream.on('close', common.mustCall(() => {
server.close();
server.close(common.mustCall());
client.destroy();
}));
stream.resume();
@ -80,6 +80,8 @@ server.on('stream', (stream) => {
stream.end('ok');
});
server.on('close', common.mustCall());
server.listen(0, () => {
client = net.connect(server.address().port, () => {
client.write(preamble);