1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

zlib: move process.binding('zlib') to internalBinding

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23307
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Anna Henningsen 2018-10-06 18:09:45 -07:00
parent d7f17b2a61
commit 09c42f45f6
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
4 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/internal/bootstrap/node.js
View File

@ -412,7 +412,8 @@
'async_wrap', 'async_wrap',
'url', 'url',
'spawn_sync', 'spawn_sync',
'js_stream']); 'js_stream',
'zlib']);
process.binding = function binding(name) { process.binding = function binding(name) {
return internalBindingWhitelist.has(name) ? return internalBindingWhitelist.has(name) ?
internalBinding(name) : internalBinding(name) :

2
lib/zlib.js
View File

@ -36,7 +36,7 @@ const {
isArrayBufferView isArrayBufferView
} }
} = require('util'); } = require('util');
const binding = process.binding('zlib'); const binding = internalBinding('zlib');
const assert = require('assert').ok; const assert = require('assert').ok;
const { const {
Buffer, Buffer,

2
src/node_zlib.cc
View File

@ -850,4 +850,4 @@ void DefineZlibConstants(Local<Object> target) {
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(zlib, node::Initialize) NODE_MODULE_CONTEXT_AWARE_INTERNAL(zlib, node::Initialize)

4
test/async-hooks/test-zlib.zlib-binding.deflate.js
View File

@ -1,3 +1,4 @@
// Flags: --expose-internals
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
@ -8,7 +9,8 @@ const { checkInvocations } = require('./hook-checks');
const hooks = initHooks(); const hooks = initHooks();
hooks.enable(); hooks.enable();
const Zlib = process.binding('zlib').Zlib; const { internalBinding } = require('internal/test/binding');
const { Zlib } = internalBinding('zlib');
const constants = process.binding('constants').zlib; const constants = process.binding('constants').zlib;
const handle = new Zlib(constants.DEFLATE); const handle = new Zlib(constants.DEFLATE);