1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: fix http2stream.pushStream error doc

Browse Source 
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd181a0c5d775e62a12b3b04fe4d7654fe80a (pull request #17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by #21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: https://github.com/nodejs/node/pull/21470
Refs: https://github.com/nodejs/node/pull/17406
PR-URL: https://github.com/nodejs/node/pull/21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Сковорода Никита Андреевич 2018-06-23 14:48:54 +03:00
parent 195480a8bc
commit 094346c955
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/api/http2.md
View File

@ -3143,7 +3143,7 @@ added: v8.4.0
Call [`http2stream.pushStream()`][] with the given headers, and wraps the
given newly created [`Http2Stream`] on `Http2ServerResponse`.
The callback will be called with an error with code `ERR_HTTP2_STREAM_CLOSED`
The callback will be called with an error with code `ERR_HTTP2_INVALID_STREAM`
if the stream is closed.
## Collecting HTTP/2 Performance Metrics