1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

console: apply null as this for util.format

Browse Source 
Util.format is just a stateless function. Apply current console
as `this` is unnecessary.

PR-URL: https://github.com/nodejs/node/pull/5222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
This commit is contained in:
Jackson Tian 2016-02-14 15:32:33 +08:00 committed by Michaël Zasso
parent 0cb0287f8a
commit 0903b6d8a8
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/console.js
View File

@ -33,7 +33,7 @@ function Console(stdout, stderr) {
} }
Console.prototype.log = function() { Console.prototype.log = function() {
this._stdout.write(util.format.apply(this, arguments) + '\n'); this._stdout.write(util.format.apply(null, arguments) + '\n');
}; };
@ -41,7 +41,7 @@ Console.prototype.info = Console.prototype.log;
Console.prototype.warn = function() { Console.prototype.warn = function() {
this._stderr.write(util.format.apply(this, arguments) + '\n'); this._stderr.write(util.format.apply(null, arguments) + '\n');
}; };
@ -77,7 +77,7 @@ Console.prototype.trace = function trace() {
// exposed. // exposed.
var err = new Error(); var err = new Error();
err.name = 'Trace'; err.name = 'Trace';
err.message = util.format.apply(this, arguments); err.message = util.format.apply(null, arguments);
Error.captureStackTrace(err, trace); Error.captureStackTrace(err, trace);
this.error(err.stack); this.error(err.stack);
}; };
@ -86,7 +86,7 @@ Console.prototype.trace = function trace() {
Console.prototype.assert = function(expression) { Console.prototype.assert = function(expression) {
if (!expression) { if (!expression) {
var arr = Array.prototype.slice.call(arguments, 1); var arr = Array.prototype.slice.call(arguments, 1);
require('assert').ok(false, util.format.apply(this, arr)); require('assert').ok(false, util.format.apply(null, arr));
} }
}; };