1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-dgram-membership

Browse Source 
* match full error message in assert.throws()
* wrapped function -> .bind()

PR-URL: https://github.com/nodejs/node/pull/11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-02-14 13:45:58 -08:00 committed by James M Snell
parent eeae3bd071
commit 08f15d85d3
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-dgram-membership.js
View File

@ -5,9 +5,7 @@ const assert = require('assert');
const dgram = require('dgram'); const dgram = require('dgram');
const multicastAddress = '224.0.0.114'; const multicastAddress = '224.0.0.114';
const setup = () => { const setup = dgram.createSocket.bind(dgram, {type: 'udp4', reuseAddr: true});
return dgram.createSocket({type: 'udp4', reuseAddr: true});
};
// addMembership() on closed socket should throw // addMembership() on closed socket should throw
{ {
@ -46,14 +44,16 @@ const setup = () => {
// addMembership() with invalid multicast address should throw // addMembership() with invalid multicast address should throw
{ {
const socket = setup(); const socket = setup();
assert.throws(() => { socket.addMembership('256.256.256.256'); }, /EINVAL/); assert.throws(() => { socket.addMembership('256.256.256.256'); },
/^Error: addMembership EINVAL$/);
socket.close(); socket.close();
} }
// dropMembership() with invalid multicast address should throw // dropMembership() with invalid multicast address should throw
{ {
const socket = setup(); const socket = setup();
assert.throws(() => { socket.dropMembership('256.256.256.256'); }, /EINVAL/); assert.throws(() => { socket.dropMembership('256.256.256.256'); },
/^Error: dropMembership EINVAL$/);
socket.close(); socket.close();
} }