1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

console: improve code readability

Browse Source 
use object spread to make console code more readable

PR-URL: https://github.com/nodejs/node/pull/24412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
gengjiawen 2018-11-15 23:40:36 +08:00 committed by Rich Trott
parent 527b6096a4
commit 08c14d98cd
1 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
lib/console.js
View File

@ -97,23 +97,26 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {
throw new ERR_CONSOLE_WRITABLE_STREAM('stderr'); throw new ERR_CONSOLE_WRITABLE_STREAM('stderr');
} }
var prop = { const prop = {
writable: true, writable: true,
enumerable: false, enumerable: false,
configurable: true configurable: true
}; };
prop.value = stdout; Object.defineProperty(this, '_stdout', { ...prop, value: stdout });
Object.defineProperty(this, '_stdout', prop); Object.defineProperty(this, '_stderr', { ...prop, value: stderr });
prop.value = stderr; Object.defineProperty(this, '_ignoreErrors', {
Object.defineProperty(this, '_stderr', prop); ...prop,
prop.value = Boolean(ignoreErrors); value: Boolean(ignoreErrors),
Object.defineProperty(this, '_ignoreErrors', prop); });
prop.value = new Map(); Object.defineProperty(this, '_times', { ...prop, value: new Map() });
Object.defineProperty(this, '_times', prop); Object.defineProperty(this, '_stdoutErrorHandler', {
prop.value = createWriteErrorHandler(stdout); ...prop,
Object.defineProperty(this, '_stdoutErrorHandler', prop); value: createWriteErrorHandler(stdout),
prop.value = createWriteErrorHandler(stderr); });
Object.defineProperty(this, '_stderrErrorHandler', prop); Object.defineProperty(this, '_stderrErrorHandler', {
...prop,
value: createWriteErrorHandler(stderr),
});
if (typeof colorMode !== 'boolean' && colorMode !== 'auto') if (typeof colorMode !== 'boolean' && colorMode !== 'auto')
throw new ERR_INVALID_ARG_VALUE('colorMode', colorMode); throw new ERR_INVALID_ARG_VALUE('colorMode', colorMode);