1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: increase coverage by removing dead code

Browse Source 
buffer.js:L196 `if (value == null)` guarantees `obj != null`
so L406+L418 are unnecessary.

PR-URL: https://github.com/nodejs/node/pull/15100
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Marcelo Gobelli 2017-08-30 10:18:40 -07:00 committed by Refael Ackermann
parent b12d77977e
commit 08984b26d3
No known key found for this signature in database
GPG Key ID: CD704BD80FDDDB64
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/buffer.js
View File

@ -404,7 +404,6 @@ function fromObject(obj) {
return b; return b;
} }
if (obj != null) {
if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) { if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) {
if (typeof obj.length !== 'number' || obj.length !== obj.length) { if (typeof obj.length !== 'number' || obj.length !== obj.length) {
return new FastBuffer(); return new FastBuffer();
@ -415,7 +414,6 @@ function fromObject(obj) {
if (obj.type === 'Buffer' && Array.isArray(obj.data)) { if (obj.type === 'Buffer' && Array.isArray(obj.data)) {
return fromArrayLike(obj.data); return fromArrayLike(obj.data);
} }
}
} }