1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: change ciphers from RC4 to no-such-cipher

Browse Source 
This commit updates option ciphers from 'RC4' to 'no-such-cipher' in
test/parallel/test-tls-handshake-error.js.

The motivation for this change is that this test is verifying that a
'no ciphers match' error be thrown, but 'RC4' might be among the ciphers
supported by the OpenSSL version when dynamically linking. I ran into
this specific issue when dynamically linking against OpenSSL 1.1.1 on
RHEL8 using https://github.com/nodejs/node/pull/25381.

PR-URL: https://github.com/nodejs/node/pull/25534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Daniel Bevenius 2019-01-16 12:28:48 +01:00
parent af102c6d27
commit 07e0c4eaa3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-tls-handshake-error.js
View File

@ -19,7 +19,7 @@ const server = tls.createServer({
assert.throws(() => { assert.throws(() => {
tls.connect({ tls.connect({
port: this.address().port, port: this.address().port,
ciphers: 'RC4' ciphers: 'no-such-cipher'
}, common.mustNotCall()); }, common.mustNotCall());
}, /no cipher match/i); }, /no cipher match/i);