1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: assert that uv_async_init() succeeds

Browse Source 
This commit fixes two coverity warnings for unchecked
return values.

Refs: https://github.com/nodejs/node/pull/13050
PR-URL: https://github.com/nodejs/node/pull/13116
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This commit is contained in:
cjihrig 2017-05-19 12:18:20 -04:00
parent f8c617dbe2
commit 06f62eb384
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cares_wrap.cc
View File

@ -534,7 +534,9 @@ class QueryWrap : public AsyncWrap {
data->len = answer_len; data->len = answer_len;
uv_async_t* async_handle = &data->async_handle; uv_async_t* async_handle = &data->async_handle;
uv_async_init(wrap->env()->event_loop(), async_handle, CaresAsyncCb); CHECK_EQ(0, uv_async_init(wrap->env()->event_loop(),
async_handle,
CaresAsyncCb));
wrap->env()->set_cares_query_last_ok(status != ARES_ECONNREFUSED); wrap->env()->set_cares_query_last_ok(status != ARES_ECONNREFUSED);
async_handle->data = data; async_handle->data = data;
@ -558,7 +560,9 @@ class QueryWrap : public AsyncWrap {
data->is_host = true; data->is_host = true;
uv_async_t* async_handle = &data->async_handle; uv_async_t* async_handle = &data->async_handle;
uv_async_init(wrap->env()->event_loop(), async_handle, CaresAsyncCb); CHECK_EQ(0, uv_async_init(wrap->env()->event_loop(),
async_handle,
CaresAsyncCb));
wrap->env()->set_cares_query_last_ok(status != ARES_ECONNREFUSED); wrap->env()->set_cares_query_last_ok(status != ARES_ECONNREFUSED);
async_handle->data = data; async_handle->data = data;