1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

streams2: Correct drain/return logic

Browse Source 
It was testing the length *before* adding the current chunk, which
is the opposite of correct.

Also, the return value was flipped.
This commit is contained in:
isaacs 2012-10-05 07:45:03 -07:00
parent 02f017d24f
commit 06e321d0f9
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/_stream_writable.js
View File

@ -71,13 +71,13 @@ Writable.prototype.write = function(chunk, encoding) {
if (typeof chunk === 'string') if (typeof chunk === 'string')
chunk = new Buffer(chunk, encoding); chunk = new Buffer(chunk, encoding);
var ret = state.length >= state.highWaterMark;
if (ret === false)
state.needDrain = true;
var l = chunk.length; var l = chunk.length;
state.length += l; state.length += l;
var ret = state.length < state.highWaterMark;
if (ret === false)
state.needDrain = true;
if (state.writing) { if (state.writing) {
state.buffer.push(chunk); state.buffer.push(chunk);
return ret; return ret;