1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: don't connect to :: (use localhost instead)

Browse Source 
If a test does http.listen(0) or net.listen(0),
http.listen(0).address().address returns '::'. Some machines will
resolve this to localhost, but not all. Every machine should have
localhost defined in /etc/hosts (or equivalent), so it should always
resolve.

Fixes: https://github.com/nodejs/node/issues/7291
PR-URL: https://github.com/nodejs/node/pull/10854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
This commit is contained in:
Gibson Fahnestock 2017-01-17 10:30:43 +00:00 committed by James M Snell
parent dcab88d529
commit 067be658f9
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/gc/test-net-timeout.js
View File

@ -35,7 +35,7 @@ function getall() {
if (count >= todo) if (count >= todo)
return; return;
const req = net.connect(server.address().port, server.address().address); const req = net.connect(server.address().port);
req.resume(); req.resume();
req.setTimeout(10, function() { req.setTimeout(10, function() {
req.destroy(); req.destroy();

4
test/parallel/test-http-status-reason-invalid-chars.js
View File

@ -3,7 +3,6 @@
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const http = require('http'); const http = require('http');
const net = require('net');
function explicit(req, res) { function explicit(req, res) {
assert.throws(() => { assert.throws(() => {
@ -34,8 +33,7 @@ const server = http.createServer((req, res) => {
implicit(req, res); implicit(req, res);
} }
}).listen(0, common.mustCall(() => { }).listen(0, common.mustCall(() => {
const addr = server.address().address; const hostname = 'localhost';
const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr;
const url = `http://${hostname}:${server.address().port}`; const url = `http://${hostname}:${server.address().port}`;
let left = 2; let left = 2;
const check = common.mustCall((res) => { const check = common.mustCall((res) => {