1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-tls-env-extra-ca

Browse Source 
* Use `common.mustCall()` to guarantee callback invocations
* Order modules according to test writing guide

PR-URL: https://github.com/nodejs/node/pull/13886
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
Rich Trott 2017-06-22 21:59:11 -07:00
parent d71d7a1bc7
commit 062c414f5c
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/parallel/test-tls-env-extra-ca.js
View File

@ -9,18 +9,19 @@ if (!common.hasCrypto) {
} }
const assert = require('assert'); const assert = require('assert');
const tls = require('tls');
const fork = require('child_process').fork;
const fs = require('fs'); const fs = require('fs');
const tls = require('tls');
const fork = require('child_process').fork;
if (process.env.CHILD) { if (process.env.CHILD) {
const copts = { const copts = {
port: process.env.PORT, port: process.env.PORT,
checkServerIdentity: common.noop, checkServerIdentity: common.mustCall(),
}; };
const client = tls.connect(copts, function() { const client = tls.connect(copts, common.mustCall(function() {
client.end('hi'); client.end('hi');
}); }));
return; return;
} }
@ -29,10 +30,10 @@ const options = {
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`), cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`),
}; };
const server = tls.createServer(options, function(s) { const server = tls.createServer(options, common.mustCall(function(s) {
s.end('bye'); s.end('bye');
server.close(); server.close();
}).listen(0, common.mustCall(function() { })).listen(0, common.mustCall(function() {
const env = { const env = {
CHILD: 'yes', CHILD: 'yes',
PORT: this.address().port, PORT: this.address().port,