1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: update onboarding task

Browse Source 
Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.

PR-URL: https://github.com/nodejs/node/pull/23300
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Rich Trott 2018-10-06 15:36:08 -07:00
parent f423579498
commit 061e09891c
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/onboarding.md
View File

@ -210,11 +210,12 @@ needs to be pointed out separately during the onboarding.
-1` -1`
* Collaborators are in alphabetical order by GitHub username. * Collaborators are in alphabetical order by GitHub username.
* Optionally, include your personal pronouns. * Optionally, include your personal pronouns.
* Label your pull request with the `doc` and `notable-change` labels. * Label your pull request with the `doc`, `notable-change`, and `fast-track`
labels.
* Run CI on the PR. Because the PR does not affect any code, use the * Run CI on the PR. Because the PR does not affect any code, use the
`node-test-pull-request-lite-pipeline` CI task. `node-test-pull-request-lite-pipeline` CI task.
* After one or two approvals, land the PR (PRs of this type do not need to wait * After two Collaborator approvals for the change and two Collaborator approvals
for 48 hours to land). for fast-tracking, land the PR.
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
metadata. metadata.
* [`node-core-utils`][] automates the generation of metadata and the landing * [`node-core-utils`][] automates the generation of metadata and the landing