1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: use strict comparisons for fd

Browse Source 
This commit removes an eslint-disable comment, and moves file
descriptor checks to use strict equality. These checks were
using loose equality to support numeric and string file
descriptors. However, d9e95d8982ee5b409b36f09c77feccbb1040095c
introduced strict validation, making the loose equality checks
redundant.

PR-URL: https://github.com/nodejs/node/pull/25014
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
cjihrig 2018-12-13 09:11:13 -05:00
parent 0fdd23fa3f
commit 06134e3598
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/net.js
View File

@ -281,11 +281,8 @@ function Socket(options) {
throw errnoException(err, 'open'); throw errnoException(err, 'open');
this[async_id_symbol] = this._handle.getAsyncId(); this[async_id_symbol] = this._handle.getAsyncId();
// options.fd can be string (since it is user-defined),
// so changing this to === would be semver-major if ((fd === 1 || fd === 2) &&
// See: https://github.com/nodejs/node/pull/11513
// eslint-disable-next-line eqeqeq
if ((fd == 1 || fd == 2) &&
(this._handle instanceof Pipe) && (this._handle instanceof Pipe) &&
process.platform === 'win32') { process.platform === 'win32') {
// Make stdout and stderr blocking on Windows // Make stdout and stderr blocking on Windows