1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-fs-buffer

Browse Source 
* Remove unneeded temp dir cleanup
* Add check for error in `.close()` callback
* Improve error reporting

On that last bullet point, the previous version of the test reported
errors like this:

```
AssertionError: [ '.empty-repl-history-file',
  '.node_repl_history',
  'GH-1899-output.js',
  'GH-892-request.js',
  'a.js',
  'a1.js',
  'agen deepStrictEqual [ '.empty-repl-history-file',
  '.node_repl_history',
  'GH-1899-output.js',
  'GH-892-request.js',
  'a.js',
  'a1.js',
  'agen
```

Now, they look like this:

```
AssertionError: expected *, got ! by hex decoding 2a
```

PR-URL: https://github.com/nodejs/node/pull/11232
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-02-07 20:44:53 -08:00
parent 595df9fc4b
commit 05be62307d
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/parallel/test-fs-buffer.js
View File

@ -18,8 +18,8 @@ assert.doesNotThrow(() => {
fs.open(buf, 'w+', common.mustCall((err, fd) => {
assert.ifError(err);
assert(fd);
fs.close(fd, common.mustCall(() => {
fs.unlinkSync(buf);
fs.close(fd, common.mustCall((err) => {
assert.ifError(err);
}));
}));
});
@ -29,13 +29,17 @@ assert.throws(() => {
}, /path must be a string or Buffer/);
const dir = Buffer.from(common.fixturesDir);
fs.readdir(dir, 'hex', common.mustCall((err, list) => {
fs.readdir(dir, 'hex', common.mustCall((err, hexList) => {
assert.ifError(err);
list = list.map((i) => {
return Buffer.from(i, 'hex').toString();
});
fs.readdir(dir, common.mustCall((err, list2) => {
fs.readdir(dir, common.mustCall((err, stringList) => {
assert.ifError(err);
assert.deepStrictEqual(list, list2);
stringList.forEach((val, idx) => {
const fromHexList = Buffer.from(hexList[idx], 'hex').toString();
assert.strictEqual(
fromHexList,
val,
`expected ${val}, got ${fromHexList} by hex decoding ${hexList[idx]}`
);
});
}));
}));