From 04633eeeb93c5a86a6635940eb4f34a7839ada11 Mon Sep 17 00:00:00 2001
From: Sam Roberts <vieuxtech@gmail.com>
Date: Mon, 3 Jun 2019 00:48:53 +0200
Subject: [PATCH] readline: error on falsy values for callback

It was intended, according to in-test comments and common behaviour,
that callbacks be either `undefined` or a function, but falsy values
were being accepted as meaning "no callback".

PR-URL: https://github.com/nodejs/node/pull/28109
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
---
 lib/readline.js                          |  2 +-
 test/parallel/test-readline-interface.js | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/lib/readline.js b/lib/readline.js
index c8d0a8040ad..5cc22938821 100644
--- a/lib/readline.js
+++ b/lib/readline.js
@@ -121,7 +121,7 @@ function Interface(input, output, completer, terminal) {
     input = input.input;
   }
 
-  if (completer && typeof completer !== 'function') {
+  if (completer !== undefined && typeof completer !== 'function') {
     throw new ERR_INVALID_OPT_VALUE('completer', completer);
   }
 
diff --git a/test/parallel/test-readline-interface.js b/test/parallel/test-readline-interface.js
index 2dff11f2a27..93c4b12511e 100644
--- a/test/parallel/test-readline-interface.js
+++ b/test/parallel/test-readline-interface.js
@@ -366,6 +366,26 @@ function isWarned(emitter) {
       type: TypeError,
       code: 'ERR_INVALID_OPT_VALUE'
     });
+
+    common.expectsError(function() {
+      readline.createInterface({
+        input: fi,
+        completer: ''
+      });
+    }, {
+      type: TypeError,
+      code: 'ERR_INVALID_OPT_VALUE'
+    });
+
+    common.expectsError(function() {
+      readline.createInterface({
+        input: fi,
+        completer: false
+      });
+    }, {
+      type: TypeError,
+      code: 'ERR_INVALID_OPT_VALUE'
+    });
   }
 
   // Constructor throws if historySize is not a positive number