From 03e9f84933fe610b04b107cf1f83d17485e8906e Mon Sep 17 00:00:00 2001 From: Brian White Date: Wed, 11 Jun 2014 15:16:48 -0400 Subject: [PATCH] lib: remove unused variables Signed-off-by: Fedor Indutny --- lib/_http_client.js | 1 - lib/_stream_transform.js | 4 ++-- lib/_tls_legacy.js | 10 ---------- lib/child_process.js | 1 - lib/domain.js | 5 +---- lib/fs.js | 4 ---- lib/http.js | 8 +++----- lib/net.js | 24 ------------------------ lib/repl.js | 2 +- lib/tracing.js | 3 +-- lib/zlib.js | 1 - 11 files changed, 8 insertions(+), 55 deletions(-) diff --git a/lib/_http_client.js b/lib/_http_client.js index 0c0dc516883..8582e727b74 100644 --- a/lib/_http_client.js +++ b/lib/_http_client.js @@ -33,7 +33,6 @@ var parsers = common.parsers; var freeParser = common.freeParser; var debug = common.debug; -var IncomingMessage = require('_http_incoming').IncomingMessage; var OutgoingMessage = require('_http_outgoing').OutgoingMessage; var Agent = require('_http_agent'); diff --git a/lib/_stream_transform.js b/lib/_stream_transform.js index b1f9fcce112..1843f51b751 100644 --- a/lib/_stream_transform.js +++ b/lib/_stream_transform.js @@ -69,7 +69,7 @@ var util = require('util'); util.inherits(Transform, Duplex); -function TransformState(options, stream) { +function TransformState(stream) { this.afterTransform = function(er, data) { return afterTransform(stream, er, data); }; @@ -112,7 +112,7 @@ function Transform(options) { Duplex.call(this, options); - this._transformState = new TransformState(options, this); + this._transformState = new TransformState(this); // when the writable side finishes, then flush out anything remaining. var stream = this; diff --git a/lib/_tls_legacy.js b/lib/_tls_legacy.js index c6ba34a4f4d..89e289e3d33 100644 --- a/lib/_tls_legacy.js +++ b/lib/_tls_legacy.js @@ -20,7 +20,6 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. var assert = require('assert'); -var crypto = require('crypto'); var events = require('events'); var stream = require('stream'); var tls = require('tls'); @@ -664,15 +663,6 @@ function onnewsession(key, session) { } -function onnewsessiondone() { - if (!this.server) return; - - // Cycle through data - this.cleartext.read(0); - this.encrypted.read(0); -} - - function onocspresponse(resp) { this.emit('OCSPResponse', resp); } diff --git a/lib/child_process.js b/lib/child_process.js index d4b4449fc64..462decbd843 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -1251,7 +1251,6 @@ function spawnSync(/*file, args, options*/) { var opts = normalizeSpawnArguments.apply(null, arguments); var options = opts.options; - var envPairs = opts.envPairs; var i; diff --git a/lib/domain.js b/lib/domain.js index f18cca6ebaa..5924b44ebdf 100644 --- a/lib/domain.js +++ b/lib/domain.js @@ -215,7 +215,6 @@ function intercepted(_this, self, cb, fnargs) { return; } - var len = fnargs.length; var args = []; var i, ret; @@ -248,9 +247,7 @@ function bound(_this, self, cb, fnargs) { if (self._disposed) return; - var len = fnargs.length; - var args = []; - var i, ret; + var ret; self.enter(); if (fnargs.length > 0) diff --git a/lib/fs.js b/lib/fs.js index aabe68655f8..bdad8f4f6c2 100644 --- a/lib/fs.js +++ b/lib/fs.js @@ -42,13 +42,9 @@ var kMaxLength = require('smalloc').kMaxLength; var O_APPEND = constants.O_APPEND || 0; var O_CREAT = constants.O_CREAT || 0; -var O_DIRECTORY = constants.O_DIRECTORY || 0; var O_EXCL = constants.O_EXCL || 0; -var O_NOCTTY = constants.O_NOCTTY || 0; -var O_NOFOLLOW = constants.O_NOFOLLOW || 0; var O_RDONLY = constants.O_RDONLY || 0; var O_RDWR = constants.O_RDWR || 0; -var O_SYMLINK = constants.O_SYMLINK || 0; var O_SYNC = constants.O_SYNC || 0; var O_TRUNC = constants.O_TRUNC || 0; var O_WRONLY = constants.O_WRONLY || 0; diff --git a/lib/http.js b/lib/http.js index db87b589b58..9a59fd9a313 100644 --- a/lib/http.js +++ b/lib/http.js @@ -23,8 +23,7 @@ var util = require('util'); var EventEmitter = require('events').EventEmitter; -var incoming = require('_http_incoming'); -var IncomingMessage = exports.IncomingMessage = incoming.IncomingMessage; +exports.IncomingMessage = require('_http_incoming').IncomingMessage; var common = require('_http_common'); @@ -32,8 +31,7 @@ exports.METHODS = util._extend([], common.methods).sort(); exports.parsers = common.parsers; -var outgoing = require('_http_outgoing'); -var OutgoingMessage = exports.OutgoingMessage = outgoing.OutgoingMessage; +exports.OutgoingMessage = require('_http_outgoing').OutgoingMessage; var server = require('_http_server'); @@ -43,7 +41,7 @@ exports.STATUS_CODES = server.STATUS_CODES; var agent = require('_http_agent'); var Agent = exports.Agent = agent.Agent; -var globalAgent = exports.globalAgent = agent.globalAgent; +exports.globalAgent = agent.globalAgent; var client = require('_http_client'); var ClientRequest = exports.ClientRequest = client.ClientRequest; diff --git a/lib/net.js b/lib/net.js index 1af61f3bd91..770f34ed4e1 100644 --- a/lib/net.js +++ b/lib/net.js @@ -679,30 +679,6 @@ Socket.prototype._write = function(data, encoding, cb) { this._writeGeneric(false, data, encoding, cb); }; -// Important: this should have the same values as in src/stream_wrap.h -function getEncodingId(encoding) { - switch (encoding) { - case 'buffer': - return 0; - - case 'utf8': - case 'utf-8': - return 1; - - case 'ascii': - return 2; - - case 'ucs2': - case 'ucs-2': - case 'utf16le': - case 'utf-16le': - return 3; - - default: - return 0; - } -} - function createWriteReq(req, handle, data, encoding) { switch (encoding) { case 'buffer': diff --git a/lib/repl.js b/lib/repl.js index 823f36c34ab..b458d1fd198 100644 --- a/lib/repl.js +++ b/lib/repl.js @@ -556,7 +556,7 @@ REPLServer.prototype.complete = function(line, callback) { } // Resolve expr and get its completions. - var obj, memberGroups = []; + var memberGroups = []; if (!expr) { // If context is instance of vm.ScriptContext // Get global vars synchronously diff --git a/lib/tracing.js b/lib/tracing.js index 75dd52f2a5a..49d0dec35c2 100644 --- a/lib/tracing.js +++ b/lib/tracing.js @@ -97,7 +97,6 @@ var inErrorTick = false; // Needs to be the same as src/env.h var kHasListener = 0; -var kWatchedProviders = 1; // Flags to determine what async listeners are available. var HAS_CREATE_AL = 1 << 0; @@ -143,7 +142,7 @@ function unloadContext() { function runAsyncQueue(context) { var queue = new Array(); var data = new Array(); - var ccQueue, i, item, queueItem, value; + var ccQueue, i, queueItem, value; context._asyncQueue = queue; context._asyncData = data; diff --git a/lib/zlib.js b/lib/zlib.js index 7c9c1ae4a43..2460cbb5ea1 100644 --- a/lib/zlib.js +++ b/lib/zlib.js @@ -491,7 +491,6 @@ Zlib.prototype._transform = function(chunk, encoding, cb) { } } - var self = this; this._processChunk(chunk, flushFlag, cb); };