1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use reserved invalid hostname for tests

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/14781
Refs: https://tools.ietf.org/html/rfc2606#section-2
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
icarter09 2017-08-11 23:04:41 -04:00 committed by Tobias Nießen
parent 4f1eddf84e
commit 0309619aa7
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-net-better-error-messages-port-hostname.js
View File

@ -4,12 +4,12 @@ const net = require('net');
const assert = require('assert'); const assert = require('assert');
// Using port 0 as hostname used is already invalid. // Using port 0 as hostname used is already invalid.
const c = net.createConnection(0, '***'); const c = net.createConnection(0, 'this.hostname.is.invalid');
c.on('connect', common.mustNotCall()); c.on('connect', common.mustNotCall());
c.on('error', common.mustCall(function(e) { c.on('error', common.mustCall(function(e) {
assert.strictEqual(e.code, 'ENOTFOUND'); assert.strictEqual(e.code, 'ENOTFOUND');
assert.strictEqual(e.port, 0); assert.strictEqual(e.port, 0);
assert.strictEqual(e.hostname, '***'); assert.strictEqual(e.hostname, 'this.hostname.is.invalid');
})); }));

7
test/parallel/test-net-connect-immediate-finish.js
View File

@ -24,14 +24,17 @@ const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const net = require('net'); const net = require('net');
const client = net.connect({ host: '***', port: common.PORT }); const client = net.connect({
host: 'this.hostname.is.invalid',
port: common.PORT
});
client.once('error', common.mustCall((err) => { client.once('error', common.mustCall((err) => {
assert(err); assert(err);
assert.strictEqual(err.code, err.errno); assert.strictEqual(err.code, err.errno);
assert.strictEqual(err.code, 'ENOTFOUND'); assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(err.host, err.hostname); assert.strictEqual(err.host, err.hostname);
assert.strictEqual(err.host, '***'); assert.strictEqual(err.host, 'this.hostname.is.invalid');
assert.strictEqual(err.syscall, 'getaddrinfo'); assert.strictEqual(err.syscall, 'getaddrinfo');
})); }));