1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add cases for unescape & unescapeBuffer

Browse Source 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

PR-URL: https://github.com/nodejs/node/pull/11326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Daijiro Wachi 2017-02-17 21:32:46 +01:00 committed by James M Snell
parent 7b76f822a0
commit 02acea92d2
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
test/parallel/test-querystring.js
View File

@ -123,6 +123,17 @@ const qsNoMungeTestCases = [
['trololol=yes&lololo=no', {'trololol': 'yes', 'lololo': 'no'}] ['trololol=yes&lololo=no', {'trololol': 'yes', 'lololo': 'no'}]
]; ];
const qsUnescapeTestCases = [
['there is nothing to unescape here',
'there is nothing to unescape here'],
['there%20are%20several%20spaces%20that%20need%20to%20be%20unescaped',
'there are several spaces that need to be unescaped'],
['there%2Qare%0-fake%escaped values in%%%%this%9Hstring',
'there%2Qare%0-fake%escaped values in%%%%this%9Hstring'],
['%20%21%22%23%24%25%26%27%28%29%2A%2B%2C%2D%2E%2F%30%31%32%33%34%35%36%37',
' !"#$%&\'()*+,-./01234567']
];
assert.strictEqual('918854443121279438895193', assert.strictEqual('918854443121279438895193',
qs.parse('id=918854443121279438895193').id); qs.parse('id=918854443121279438895193').id);
@ -331,6 +342,12 @@ function demoDecode(str) {
check(qs.parse('a=a&b=b&c=c', null, null, { decodeURIComponent: demoDecode }), check(qs.parse('a=a&b=b&c=c', null, null, { decodeURIComponent: demoDecode }),
{ aa: 'aa', bb: 'bb', cc: 'cc' }); { aa: 'aa', bb: 'bb', cc: 'cc' });
// Test QueryString.unescape
function errDecode(str) {
throw new Error('To jump to the catch scope');
}
check(qs.parse('a=a', null, null, { decodeURIComponent: errDecode }),
{ a: 'a' });
// Test custom encode // Test custom encode
function demoEncode(str) { function demoEncode(str) {
@ -341,6 +358,12 @@ assert.strictEqual(
qs.stringify(obj, null, null, { encodeURIComponent: demoEncode }), qs.stringify(obj, null, null, { encodeURIComponent: demoEncode }),
'a=a&b=b&c=c'); 'a=a&b=b&c=c');
// Test QueryString.unescapeBuffer
qsUnescapeTestCases.forEach(function(testCase) {
assert.strictEqual(qs.unescape(testCase[0]), testCase[1]);
assert.strictEqual(qs.unescapeBuffer(testCase[0]).toString(), testCase[1]);
});
// test overriding .unescape // test overriding .unescape
const prevUnescape = qs.unescape; const prevUnescape = qs.unescape;
qs.unescape = function(str) { qs.unescape = function(str) {