1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix proxy tab-completion test

Browse Source 
Proxies support is now complete in V8. The tests needed slight modification to
match the spec implementation.

PR-URL: https://github.com/nodejs/node/pull/4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
This commit is contained in:
Ali Ijaz Sheikh 2016-01-24 08:47:14 -08:00 committed by Ali Sheikh
parent 9968941797
commit 01f82f0685
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/parallel/test-repl-tab-complete.js
View File

@ -223,12 +223,27 @@ testMe.complete('cus', common.mustCall(function(error, data) {
putIn.run(['.clear']); putIn.run(['.clear']);
putIn.run([ putIn.run([
'var proxy = Proxy.create({});' 'var proxy = new Proxy({}, {ownKeys: () => { throw new Error(); }});'
]); ]);
const proxyElements = [ [
'proxy.__defineGetter__',
'proxy.__defineSetter__',
'proxy.__lookupGetter__',
'proxy.__lookupSetter__',
'proxy.__proto__',
'proxy.constructor',
'proxy.hasOwnProperty',
'proxy.isPrototypeOf',
'proxy.propertyIsEnumerable',
'proxy.toLocaleString',
'proxy.toString',
'proxy.valueOf' ],
'proxy.' ];
testMe.complete('proxy.', common.mustCall(function(error, data) { testMe.complete('proxy.', common.mustCall(function(error, data) {
assert.strictEqual(error, null); assert.strictEqual(error, null);
assert.deepEqual(data, [[], 'proxy.']); assert.deepEqual(data, proxyElements);
})); }));
// Make sure tab completion does not include integer members of an Array // Make sure tab completion does not include integer members of an Array