1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

contexify: fix infinite recursion in delete cb

Browse Source 
Do not ever call `Delete()` on `proxy_global_`, it will invoke
`GlobalPropertyDeleteCallback` and cause crash because of the infinite
recursion.

fix #7529
This commit is contained in:
Fedor Indutny 2014-05-16 15:32:43 +04:00 committed by Timothy J Fontaine
parent e7bfbaf891
commit 01c2a670a1
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/node_contextify.cc
View File

@ -414,10 +414,6 @@ class ContextifyContext {
bool success = PersistentToLocal(isolate, bool success = PersistentToLocal(isolate,
ctx->sandbox_)->Delete(property); ctx->sandbox_)->Delete(property);
if (!success) {
success = PersistentToLocal(isolate,
ctx->proxy_global_)->Delete(property);
}
args.GetReturnValue().Set(success); args.GetReturnValue().Set(success);
} }

7
test/simple/test-vm-context.js
View File

@ -73,3 +73,10 @@ script = vm.createScript('var assert = require(\'assert\'); assert.throws(' +
'function() { throw "hello world"; }, /hello/);', 'function() { throw "hello world"; }, /hello/);',
'some.js'); 'some.js');
script.runInNewContext({ require : require }); script.runInNewContext({ require : require });
// Issue GH-7529
script = vm.createScript('delete b');
var ctx = {};
Object.defineProperty(ctx, 'b', { configurable: false });
ctx = vm.createContext(ctx);
assert.equal(script.runInContext(ctx), false);