1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dns: fix ReferenceError in resolve() error path

Browse Source 
A typo in the variable name makes it throw a ReferenceError instead of
the expected "Unknown type" error when dns.resolve() is passed a bad
record type argument.

Fixes the following exception:

  ReferenceError: type is not defined
    at Object.exports.resolve (dns.js:189:40)
    at /Users/bnoordhuis/src/master/test/simple/test-c-ares.js:48:9
    <snip>
This commit is contained in:
Xidorn Quan 2013-03-03 12:53:51 +08:00 committed by Ben Noordhuis
parent 906f824bab
commit 009ba02e18
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dns.js
View File

@ -186,7 +186,7 @@ exports.resolve = function(domain, type_, callback_) {
if (typeof resolver === 'function') { if (typeof resolver === 'function') {
return resolver(domain, callback); return resolver(domain, callback);
} else { } else {
throw new Error('Unknown type "' + type + '"'); throw new Error('Unknown type "' + type_ + '"');
} }
}; };

5
test/simple/test-c-ares.js
View File

@ -42,6 +42,11 @@ dns.lookup('::1', function(error, result, addressType) {
assert.equal(6, addressType); assert.equal(6, addressType);
}); });
// Try calling resolve with an unsupported type.
assert.throws(function() {
dns.resolve('www.google.com', 'HI');
}, /Unknown type/);
// Windows doesn't usually have an entry for localhost 127.0.0.1 in // Windows doesn't usually have an entry for localhost 127.0.0.1 in
// C:\Windows\System32\drivers\etc\hosts // C:\Windows\System32\drivers\etc\hosts
// so we disable this test on Windows. // so we disable this test on Windows.