1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix misplaced ) in http response statuscode test

Browse Source 
This fixes a misplaced parenthesis in each of the tests in
test/parallel/test-http-response-statuscodes.js, causing the tests to
pass as long as any error was thrown, without validating the error
message.

PR-URL: https://github.com/nodejs/node/pull/10692
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Nathan Friedly 2017-01-08 16:36:19 -05:00 committed by James M Snell
parent c61d9bade0
commit 005213b43d
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/parallel/test-http-response-statuscode.js
View File

@ -11,62 +11,62 @@ const server = http.Server(common.mustCall(function(req, res) {
case 0: case 0:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead(-1); res.writeHead(-1);
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 1: case 1:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead(Infinity); res.writeHead(Infinity);
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 2: case 2:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead(NaN); res.writeHead(NaN);
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 3: case 3:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead({}); res.writeHead({});
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 4: case 4:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead(99); res.writeHead(99);
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 5: case 5:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead(1000); res.writeHead(1000);
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 6: case 6:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead('1000'); res.writeHead('1000');
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 7: case 7:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead(null); res.writeHead(null);
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 8: case 8:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead(true); res.writeHead(true);
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 9: case 9:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead([]); res.writeHead([]);
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 10: case 10:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead('this is not valid'); res.writeHead('this is not valid');
}, /invalid status code/i)); }), /invalid status code/i);
break; break;
case 11: case 11:
assert.throws(common.mustCall(() => { assert.throws(common.mustCall(() => {
res.writeHead('404 this is not valid either'); res.writeHead('404 this is not valid either');
}, /invalid status code/i)); }), /invalid status code/i);
this.close(); this.close();
break; break;
default: default: